Use the GroupVersion.Version instead of the resources' preferred version#176
Conversation
kcp-ci-bot
added
release-note-none
|
/cherry-pick release-0.32 |
|
@ntnn: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 06b3609344766c711fa7a79866040cac44fa91c3 |
kcp-ci-bot
added
the
approved
APIResource.Version may be empty: https://github.com/kubernetes/apimachinery/blob/6fa8dff7b19f13e310ef489972c8f394a9c185ad/pkg/apis/meta/v1/types.go#L1235-L1237 Additionally it reports the resources' preferred version, not the version it was listed for per APIResourceList.GroupVersion: https://github.com/kubernetes/apimachinery/blob/master/pkg/apis/meta/v1/types.go I believe this is irrelevant in most cases however we hit this when using api-syncagent against resources provided by an aggregated API server, which does not fill the .Version on the resource. Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 954265ce07d3962d21c591f3157d4f65b6c9fd6c |
github-project-automation
Bot
moved this to Done
in Platform Mesh & Kube Projects - Backlog
|
@ntnn: cannot checkout DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-0.31 |
|
@ntnn: cannot checkout DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-0.7 |
|
@ntnn: new pull request created: #177 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Summary
APIResource.Version may be empty:
https://github.com/kubernetes/apimachinery/blob/6fa8dff7b19f13e310ef489972c8f394a9c185ad/pkg/apis/meta/v1/types.go#L1235-L1237
Additionally it reports the resources' preferred version, not the version it was listed for per APIResourceList.GroupVersion: https://github.com/kubernetes/apimachinery/blob/master/pkg/apis/meta/v1/types.go
I believe this is irrelevant in most cases however we hit this when using api-syncagent against resources provided by an aggregated API server, which does not fill the .Version on the resource.
What Type of PR Is This?
/kind bug
Related Issue(s)
Fixes #
Release Notes