Skip to content

Fix typed trigger parameter bindings#36

Open
yenda wants to merge 1 commit into
juxt:mainfrom
yenda:fix/typed-trigger-param-bindings
Open

Fix typed trigger parameter bindings#36
yenda wants to merge 1 commit into
juxt:mainfrom
yenda:fix/typed-trigger-param-bindings

Conversation

@yenda

@yenda yenda commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • register type-shaped named trigger params like account: Account as rule bindings in the Rust checker
  • support optional, qualified, and generic trigger param types such as List<User?> and Map<String, String>
  • keep named literal trigger args like name: "npm run test" and field: course_name from being treated as bindings
  • mirror the behavior in the VS Code analyzer and add Rust/TypeScript regressions
  • rebase the fix onto current juxt/allium-tools:main

Addresses juxt/allium#40.

Verification

  • cargo test --workspace
  • cargo fmt -p allium-wasm --check
  • wasm-pack build crates/allium-wasm --target nodejs --out-dir ../../packages/allium-parser-wasm
  • npm run lint (exits 0; reports existing warnings in generated ignored WASM .d.ts files)
  • npm run test
  • Rust and TypeScript edge matrix for simple, optional, qualified, generic, nested generic, two-arg generic, and named literal trigger args
  • installed from this checkout with cargo install --path crates/allium --bin allium --root /home/yenda/.local --force
  • /home/yenda/lab/projects/brian/.worktrees/dfn-aai-email-capture-and-merge: allium check specs/dfn-aai.allium specs/identity-resolution.allium exits 0 with zero allium.rule.undefinedBinding; full bb allium:check still exits 1 due unrelated existing spec errors outside those target files

Also revalidated the rebased stack that includes the follow-up WASM migration PR with the Rust/WASM/Node commands above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant