Route undefined binding diagnostics through WASM#37
Open
yenda wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
analyze(source)allium.rule.undefinedBindingfindings through the Rust/WASM analyzer instead of the duplicated TypeScript text parserexists candidate,for item in items) into the Rust analyzerdocs/project/rust-checker-parity.mdthatallium.rule.undefinedBindingis now a migrated Rust/WASM-owned diagnostic for editor/LSP surfacesRationale
The existing project docs describe the TypeScript/Rust analyzer split as a transitional state: TypeScript served the editor/LSP first, while Rust/WASM was introduced later as the parser-backed path. Keeping semantic diagnostics duplicated creates drift risk; this PR migrates one concrete diagnostic lane to the Rust implementation without broadening the scope to unrelated checks.
Stack
This is logically stacked on #36 (
Fix typed trigger parameter bindings) to keep the original bug fix separate from the analyzer ownership change.Because this branch comes from a fork and the stack base branch is not available in the upstream repository, this PR targets
main. Until #36 merges, GitHub's aggregate diff includes the #36 commit; the intended review scope here is the two follow-up commits afterFix typed trigger parameter bindings.After #36 merges, this PR can be rebased or retargeted so its diff contains only the WASM migration commits.
Verification
cargo test --workspacecargo fmt -p allium-wasm --checkwasm-pack build crates/allium-wasm --target nodejs --out-dir ../../packages/allium-parser-wasmnpm run lint(exits 0; reports existing warnings in generated ignored WASM.d.tsfiles)npm run testgit diff --check