Skip to content

Conversation

@DragonFive
Copy link
Collaborator

@DragonFive DragonFive commented Dec 18, 2025

This PR is a follow-up to #557 and continues the generative recommendation work by introducing a RecType-based
orchestration layer and a layered rec batch input builder.

What’s included

  • RecType plumbing (kNone/kOneRec/kLlmRec) from RequestState -> SequenceParams -> Sequence (default: kNone)
  • Rec batch input builder layering:
    • RecBatchInputBuilder (abstract + factory)
    • OneRecBatchInputBuilder (concrete implementation for kOneRec)
    • Batch selects the builder based on RecType
  • Scheduler wiring: use create_rec_batches for the rec scheduling path and tag rec requests as RecType::kOneRec
  • Sequence behavior: OneRec-specific output is gated by rec_type == kOneRec; other types default to the standard LLM
    text decode path

Out of scope (planned follow-ups)

  • Rec worker (runtime) + input/output processors (request ingestion and result emission)
  • Concrete kLlmRec implementation (enum value reserved only)
  • OneRec model implementation + ATB graph building/integration
  • Pure NPU inference path

Roadmap checklist

@DragonFive DragonFive changed the title feat: add rec_type and onerec batch input builder for rec framework[3/6]. feat: add rec_type and onerec batch input builder for rec framework[4/6]. Dec 18, 2025
@DragonFive
Copy link
Collaborator Author

when #557 is merged, i will rebase this branch and push again.

@DragonFive DragonFive changed the title feat: add rec_type and onerec batch input builder for rec framework[4/6]. feat: add rec_type and onerec batch input builder for rec framework[4/8]. Dec 18, 2025
@DragonFive DragonFive force-pushed the feature/add_rec_batch_builder branch 3 times, most recently from 029f1fa to 5de436f Compare December 18, 2025 13:14
@DragonFive DragonFive force-pushed the feature/add_rec_batch_builder branch 4 times, most recently from 100077b to 6510dba Compare December 19, 2025 09:09
@DragonFive DragonFive force-pushed the feature/add_rec_batch_builder branch 8 times, most recently from 7647781 to 22578ca Compare December 22, 2025 10:02
@DragonFive DragonFive force-pushed the feature/add_rec_batch_builder branch from 22578ca to 51f32c1 Compare December 22, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants