-
Notifications
You must be signed in to change notification settings - Fork 103
feat: add rec_type and onerec batch input builder for rec framework[4/8]. #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DragonFive
wants to merge
1
commit into
jd-opensource:main
Choose a base branch
from
DragonFive:feature/add_rec_batch_builder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add rec_type and onerec batch input builder for rec framework[4/8]. #565
DragonFive
wants to merge
1
commit into
jd-opensource:main
from
DragonFive:feature/add_rec_batch_builder
+2,075
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Collaborator
Author
|
when #557 is merged, i will rebase this branch and push again. |
DragonFive
commented
Dec 18, 2025
DragonFive
commented
Dec 18, 2025
DragonFive
commented
Dec 18, 2025
DragonFive
commented
Dec 18, 2025
DragonFive
commented
Dec 18, 2025
DragonFive
commented
Dec 18, 2025
DragonFive
commented
Dec 18, 2025
DragonFive
commented
Dec 18, 2025
10 tasks
029f1fa to
5de436f
Compare
DragonFive
commented
Dec 18, 2025
DragonFive
commented
Dec 18, 2025
100077b to
6510dba
Compare
XuZhang99
reviewed
Dec 19, 2025
7647781 to
22578ca
Compare
22578ca to
51f32c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #557 and continues the generative recommendation work by introducing a
RecType-basedorchestration layer and a layered rec batch input builder.
What’s included
RecTypeplumbing (kNone/kOneRec/kLlmRec) fromRequestState->SequenceParams->Sequence(default:kNone)RecBatchInputBuilder(abstract + factory)OneRecBatchInputBuilder(concrete implementation forkOneRec)Batchselects the builder based onRecTypecreate_rec_batchesfor the rec scheduling path and tag rec requests asRecType::kOneRecSequencebehavior: OneRec-specific output is gated byrec_type == kOneRec; other types default to the standard LLMtext decode path
Out of scope (planned follow-ups)
kLlmRecimplementation (enum value reserved only)Roadmap checklist
RecTypeplumbing + rec batch input builder layering feat: add rec_type and onerec batch input builder for rec framework[4/8]. #565