feat: add onerec worker impl for rec framework[5/8]. #567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #565 and continues the generative recommendation work by introducing the runtime rec worker
layer for the OneRec execution path.
What’s included
RecWorkerImpl(abstract base): shared model init + rec input preparation viaBatch::prepare_rec_forward_input(...)OneRecWorkerImpl(concrete): executes the OneRec prefill flowWorkerType::RECwiring:Workernow instantiatesOneRecWorkerImpl(removes the temporaryLLMWorkerImplfallback)rec_params.encoder_sparse_embeddingorrec_params.encoder_token_ids)std::nullopt(same contract as the LLM path)XLLM_REC_INPUT_BUILDER_THREADS(driver only)Out of scope (planned follow-ups)
kLlmRecimplementation (enum value reserved only)Roadmap checklist
RecTypeplumbing + rec batch input builder layering feat: add rec_type and onerec batch input builder for rec framework[4/8]. #565