feat(paranoid-passwd): bump to 3.6.5#20
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughPackage manager manifests (Homebrew, Scoop, Chocolatey) are updated to reflect paranoid-passwd release 3.6.5. The description shifts from cryptographic password generation to a local-first password manager with CLI and TUI, the license changes from MIT to GPL-3.0-only, and download URLs and checksums are updated across all platform variants. ChangesRelease 3.6.5 Package Manifest Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
This version bump from 3.5.2 to 3.6.5 has been executed correctly. All version numbers, URLs, and checksums are consistently updated across package managers (Homebrew, Scoop, Chocolatey). The license change from MIT to GPL-3.0-only is noted as a significant modification that may impact downstream users.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
There was a problem hiding this comment.
Code Review
This pull request updates the paranoid-passwd tool to version 3.6.5 across Homebrew, Scoop, and Chocolatey package managers, including a license change from MIT to GPL-3.0-only. Review feedback suggests modernizing the Homebrew formula with architecture-specific blocks, removing redundant fields in the Scoop manifest, and improving maintainability in the Chocolatey package by explicitly declaring the license and using variables for versioning in the installation script.
| if Hardware::CPU.arm? | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.5.2/paranoid-passwd-3.5.2-darwin-arm64.tar.gz" | ||
| sha256 "f8bc20254a54f3a4fe8f6bd3da9861b0224d8072c240190ee7f84ea601f20e49" | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-darwin-arm64.tar.gz" | ||
| sha256 "6d31f82ef205a6a59be1003768bbcf73953c1a63406282416538ea4da017a522" | ||
| end | ||
| if Hardware::CPU.intel? | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.5.2/paranoid-passwd-3.5.2-darwin-amd64.tar.gz" | ||
| sha256 "8ef778a014ada299da429e0c3415d40138b8c7cecec89836606eb398ba6f75a5" | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-darwin-amd64.tar.gz" | ||
| sha256 "97e18ccf54d3d7fa645e3942181bdea1de2d5911c9c63bdd9d29aaab96121498" | ||
| end |
There was a problem hiding this comment.
For better readability and to align with modern Homebrew formula conventions, consider using on_arm and on_intel blocks instead of separate if statements for each architecture.
on_arm do
url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-darwin-arm64.tar.gz"
sha256 "6d31f82ef205a6a59be1003768bbcf73953c1a63406282416538ea4da017a522"
end
on_intel do
url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-darwin-amd64.tar.gz"
sha256 "97e18ccf54d3d7fa645e3942181bdea1de2d5911c9c63bdd9d29aaab96121498"
end| if Hardware::CPU.arm? && Hardware::CPU.is_64_bit? | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.5.2/paranoid-passwd-3.5.2-linux-arm64.tar.gz" | ||
| sha256 "dbc575fc87e204c5616b2405fd12430ce394f6349fad34927de0b7488b12c258" | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-linux-arm64.tar.gz" | ||
| sha256 "dca563f1c336e2613fe0f65d073e856dbf7d748a312a421f4bc192d6f84b9ea4" | ||
| end | ||
| if Hardware::CPU.intel? | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.5.2/paranoid-passwd-3.5.2-linux-amd64.tar.gz" | ||
| sha256 "78d5602411614d2cfc81eeb8c9472ae3424f2caefa2461457d8d8e15ffc5b876" | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-linux-amd64.tar.gz" | ||
| sha256 "cd232e5d4076ae67a575ce7c777abf2733abc477f7642e66894740f246d84cd9" | ||
| end |
There was a problem hiding this comment.
Similar to the on_macos block, you can use on_arm and on_intel blocks here for consistency and to follow modern Homebrew formula conventions. This improves readability.
on_arm do
url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-linux-arm64.tar.gz"
sha256 "dca563f1c336e2613fe0f65d073e856dbf7d748a312a421f4bc192d6f84b9ea4"
end
on_intel do
url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-linux-amd64.tar.gz"
sha256 "cd232e5d4076ae67a575ce7c777abf2733abc477f7642e66894740f246d84cd9"
end| "license": "GPL-3.0-only", | ||
| "url": "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-windows-amd64.zip", | ||
| "hash": "a585b2660d0e09b9edb4a8de27a3021b663b49e9e0717b90f56996d9df3b4d0d", |
There was a problem hiding this comment.
The top-level url and hash fields are redundant because they are already specified within the architecture block. According to Scoop's documentation, when the architecture block is used, the top-level fields are used as a fallback for systems that don't match any architecture. Since only a 64-bit version is provided, these fields can be removed to make the manifest cleaner.
"license": "GPL-3.0-only"| <id>paranoid-passwd</id> | ||
| <version>3.5.2</version> | ||
| <title>Paranoid Password Generator</title> | ||
| <version>3.6.5</version> |
| $url64 = 'https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-windows-amd64.zip' | ||
| $checksum64 = 'a585b2660d0e09b9edb4a8de27a3021b663b49e9e0717b90f56996d9df3b4d0d' |
There was a problem hiding this comment.
To improve maintainability and reduce the chance of errors in future updates, consider defining the version number in a variable and using it to construct the URL. This avoids repeating the version string.
$version = '3.6.5'
$url64 = "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v$($version)/paranoid-passwd-$($version)-windows-amd64.zip"
$checksum64 = 'a585b2660d0e09b9edb4a8de27a3021b663b49e9e0717b90f56996d9df3b4d0d'
Auto-generated from paranoid-passwd release pipeline for v3.6.5.
Summary by CodeRabbit