feat(paranoid-passwd): bump to 3.7.0#22
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR updates the Changesparanoid-passwd 3.7.0 Release Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR correctly bumps paranoid-passwd from version 3.6.5 to 3.7.0 across all package manifests (Homebrew, Scoop, and Chocolatey). All version numbers, release URLs, and checksums are consistently updated. The changes are properly auto-generated and ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the paranoid-passwd package to version 3.7.0 across Homebrew, Scoop, and Chocolatey. The changes include updating version strings, download URLs, and SHA-256 checksums for all supported platforms. Feedback focuses on improving maintainability by utilizing dynamic version variables in the Homebrew formula, Chocolatey Nuspec, and installation scripts to reduce manual updates. Additionally, a suggestion was made to remove redundant top-level fields in the Scoop manifest.
| on_macos do | ||
| if Hardware::CPU.arm? | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-darwin-arm64.tar.gz" | ||
| sha256 "6d31f82ef205a6a59be1003768bbcf73953c1a63406282416538ea4da017a522" | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.7.0/paranoid-passwd-3.7.0-darwin-arm64.tar.gz" | ||
| sha256 "cf0a59c1538c0acd08814424c31fa259383d0f6cfc51fc6d897559859d7b576c" | ||
| end | ||
| if Hardware::CPU.intel? | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-darwin-amd64.tar.gz" | ||
| sha256 "97e18ccf54d3d7fa645e3942181bdea1de2d5911c9c63bdd9d29aaab96121498" | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.7.0/paranoid-passwd-3.7.0-darwin-amd64.tar.gz" | ||
| sha256 "f542f119507ec1acb2b8b5765dc299c5520c2579297a5216ed73208f2ed5e2d2" | ||
| end | ||
| end | ||
|
|
||
| on_linux do | ||
| if Hardware::CPU.arm? && Hardware::CPU.is_64_bit? | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-linux-arm64.tar.gz" | ||
| sha256 "dca563f1c336e2613fe0f65d073e856dbf7d748a312a421f4bc192d6f84b9ea4" | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.7.0/paranoid-passwd-3.7.0-linux-arm64.tar.gz" | ||
| sha256 "867915fd82bfa60ebbebc20687800efa846870aa3b2c5abb4e36a58ee6d0192c" | ||
| end | ||
| if Hardware::CPU.intel? | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-linux-amd64.tar.gz" | ||
| sha256 "cd232e5d4076ae67a575ce7c777abf2733abc477f7642e66894740f246d84cd9" | ||
| url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.7.0/paranoid-passwd-3.7.0-linux-amd64.tar.gz" | ||
| sha256 "849ac961091dd3140e2024e9b12fad4ab3228ba7bb8b9841cac4b3e0c199ddf2" | ||
| end | ||
| end |
There was a problem hiding this comment.
For better maintainability and to reduce redundancy, you can use the version variable (defined on line 9) within the url strings. This way, you only need to update the version number in one place when a new release is out (the checksums will still need updating).
Even though this file is auto-generated, this is a good practice to incorporate into the generation script.
on_macos do
if Hardware::CPU.arm?
url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v#{version}/paranoid-passwd-#{version}-darwin-arm64.tar.gz"
sha256 "cf0a59c1538c0acd08814424c31fa259383d0f6cfc51fc6d897559859d7b576c"
end
if Hardware::CPU.intel?
url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v#{version}/paranoid-passwd-#{version}-darwin-amd64.tar.gz"
sha256 "f542f119507ec1acb2b8b5765dc299c5520c2579297a5216ed73208f2ed5e2d2"
end
end
on_linux do
if Hardware::CPU.arm? && Hardware::CPU.is_64_bit?
url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v#{version}/paranoid-passwd-#{version}-linux-arm64.tar.gz"
sha256 "867915fd82bfa60ebbebc20687800efa846870aa3b2c5abb4e36a58ee6d0192c"
end
if Hardware::CPU.intel?
url "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v#{version}/paranoid-passwd-#{version}-linux-amd64.tar.gz"
sha256 "849ac961091dd3140e2024e9b12fad4ab3228ba7bb8b9841cac4b3e0c199ddf2"
end
end| "url": "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.7.0/paranoid-passwd-3.7.0-windows-amd64.zip", | ||
| "hash": "fae9ae7906ab4b6e33c03c5cb93686f9d1b3a673e9085e3274ea296ac80d2298", |
There was a problem hiding this comment.
The top-level url and hash fields are redundant as they are already specified within the architecture block for 64bit. To simplify the manifest and avoid duplication, you can remove these top-level fields.
| </description> | ||
| <tags>password security cli tui rust paranoid</tags> | ||
| <releaseNotes>https://github.com/jbcom/paranoid-passwd/releases/tag/paranoid-passwd-v3.6.5</releaseNotes> | ||
| <releaseNotes>https://github.com/jbcom/paranoid-passwd/releases/tag/paranoid-passwd-v3.7.0</releaseNotes> |
There was a problem hiding this comment.
To improve maintainability and avoid hardcoding the version in multiple places, you can use the $version$ replacement token in the releaseNotes URL. This token will be automatically replaced with the value from the <version> tag when the package is built.
<releaseNotes>https://github.com/jbcom/paranoid-passwd/releases/tag/paranoid-passwd-v$version$</releaseNotes>
| $toolsDir = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)" | ||
| $url64 = 'https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.6.5/paranoid-passwd-3.6.5-windows-amd64.zip' | ||
| $checksum64 = 'a585b2660d0e09b9edb4a8de27a3021b663b49e9e0717b90f56996d9df3b4d0d' | ||
| $url64 = 'https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v3.7.0/paranoid-passwd-3.7.0-windows-amd64.zip' |
There was a problem hiding this comment.
To improve maintainability, you can construct the download URL dynamically using the $env:ChocolateyPackageVersion environment variable, which Chocolatey sets based on the version in the .nuspec file. This removes the need to update the version number in the URL string manually for each release.
$url64 = "https://github.com/jbcom/paranoid-passwd/releases/download/paranoid-passwd-v$($env:ChocolateyPackageVersion)/paranoid-passwd-$($env:ChocolateyPackageVersion)-windows-amd64.zip"
1 participant
Auto-generated from paranoid-passwd release pipeline for v3.7.0.
Summary by CodeRabbit