Skip to content

fix: avoid double searchPath call, use full path for editors on Windows #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bhumika-SN wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: avoid double searchPath call, use full path for editors on Windows #2460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02fc058
fix: avoid double searchPath call using single map+filter on Windows
Bhumika-SN May 9, 2026
a70a395
fix: remove old return statement, use single map+filter
Bhumika-SN May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/main/java/dev/jbang/cli/Edit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import java.nio.charset.Charset;
import java.nio.file.*;
import java.util.*;
import java.util.Objects;
import java.util.concurrent.Callable;
import java.util.function.Function;
import java.util.stream.Collectors;
Expand Down Expand Up @@ -379,7 +380,15 @@ private static void setupEditor(Path editorBinPath, Path dataPath) throws IOExce
}

private static List<String> findEditorsOnPath() {
return Arrays.stream(knownEditors).filter(e -> Util.searchPath(e) != null).collect(Collectors.toList());
return Arrays.stream(knownEditors)
.map(e -> {
Path found = Util.searchPath(e);
if (found == null)
return null;
return Util.isWindows() ? found.toString() : e;
})
.filter(Objects::nonNull)
.collect(Collectors.toList());
}

private static void showStartingMsg(String ed, boolean showConfig) {
Expand Down
Loading