fix: avoid double searchPath call, use full path for editors on Windows#2460
Open
Bhumika-SN wants to merge 2 commits into
Open
fix: avoid double searchPath call, use full path for editors on Windows#2460Bhumika-SN wants to merge 2 commits into
Bhumika-SN wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #1340
On Windows with Git Bash,
jbang editfinds IntelliJ'sideaonPATH correctly but then tries to execute just
"idea"instead ofthe full path like
"idea.bat".findEditorsOnPath()was callingsearchPath()twice — once infilterand once inmap— which is inefficient.Fix
Use a single
map + filterto callsearchPath()only once.On Windows, return the full resolved path with extension so Git
Bash can execute it correctly.