Skip to content

Use consistent X and Y indexing in pycuampcor deramp #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bhawkins wants to merge 3 commits into from
Closed

Use consistent X and Y indexing in pycuampcor deramp #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f969f3
Use consistent X and Y indexing.
bhawkins Dec 5, 2025
329d546
Ditto in CPU version.
bhawkins Dec 5, 2025
c9f5370
update golden data
bhawkins Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cxx/isce3/cuda/matchtemplate/pycuampcor/cuDeramp.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ __global__ void cuDerampMethod1_kernel(float2 *images, const int imageNX, int co

for (int i = tid; i < imageSize; i += nthreads)
{
pixelIdxX = i%imageNY;
pixelIdxY = i/imageNY;
pixelIdxX = i / imageNY;
pixelIdxY = i % imageNY;
float phase = pixelIdxX*phaseX + pixelIdxY*phaseY;
float2 phase_factor = make_float2(cosf(phase), sinf(phase));
image[i] *= phase_factor;
Expand Down
4 changes: 2 additions & 2 deletions cxx/isce3/matchtemplate/pycuampcor/cuDeramp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ static void cuDerampMethod1_kernel(float2 *images, const int imageNX, int const
float phaseY = atan2f(phaseDiffY.y, phaseDiffY.x);

for (int i = 0; i < imageSize; i++) {
const int pixelIdxX = i%imageNY;
const int pixelIdxY = i/imageNY;
const int pixelIdxX = i / imageNY;
const int pixelIdxY = i % imageNY;
float phase = pixelIdxX*phaseX + pixelIdxY*phaseY;
float2 phase_factor = make_float2(cosf(phase), sinf(phase));
image[i] *= phase_factor;
Expand Down
Binary file modified tests/data/ampcor/accuracy-testdata/ovs128-rho0.8/golden/correlation_peak
View file
Open in desktop
Binary file not shown.
Binary file modified tests/data/ampcor/accuracy-testdata/ovs128-rho0.8/golden/dense_offsets
View file
Open in desktop
Binary file not shown.