Skip to content

Remove deprecated shell_streams and _parent_header shims #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erikgaas wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove deprecated shell_streams and _parent_header shims #1504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
108ccb7
Remove deprecated shell_streams shim
erikgaas Mar 6, 2026
4c3d077
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 6, 2026
8466774
remove parent_header
erikgaas Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 0 additions & 44 deletions ipykernel/kernelbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,45 +110,10 @@ def _update_eventloop(self, change):
profile_dir = Instance("IPython.core.profiledir.ProfileDir", allow_none=True)
shell_stream = Instance(ZMQStream, allow_none=True)

shell_streams: List[t.Any] = List(
help="""Deprecated shell_streams alias. Use shell_stream

.. versionchanged:: 6.0
shell_streams is deprecated. Use shell_stream.
"""
)

implementation: str
implementation_version: str
banner: str

@default("shell_streams")
def _shell_streams_default(self): # pragma: no cover
warnings.warn(
"Kernel.shell_streams is deprecated in ipykernel 6.0. Use Kernel.shell_stream",
DeprecationWarning,
stacklevel=2,
)
if self.shell_stream is not None:
return [self.shell_stream]
return []

@observe("shell_streams")
def _shell_streams_changed(self, change): # pragma: no cover
warnings.warn(
"Kernel.shell_streams is deprecated in ipykernel 6.0. Use Kernel.shell_stream",
DeprecationWarning,
stacklevel=2,
)
if len(change.new) > 1:
warnings.warn(
"Kernel only supports one shell stream. Additional streams will be ignored.",
RuntimeWarning,
stacklevel=2,
)
if change.new:
self.shell_stream = change.new[0]

control_stream = Instance(ZMQStream, allow_none=True)

debug_shell_socket = Any()
Expand Down Expand Up @@ -216,15 +181,6 @@ def _default_ident(self):
# Asyncio lock for main shell thread.
_main_asyncio_lock: asyncio.Lock

@property
def _parent_header(self):
warnings.warn(
"Kernel._parent_header is deprecated in ipykernel 6. Use .get_parent()",
DeprecationWarning,
stacklevel=2,
)
return self.get_parent()

# Time to sleep after flushing the stdout/err buffers in each execute
# cycle. While this introduces a hard limit on the minimal latency of the
# execute cycle, it helps prevent output synchronization problems for
Expand Down
13 changes: 0 additions & 13 deletions tests/test_kernel_direct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
# Distributed under the terms of the Modified BSD License.

import os
import warnings

import pytest

Expand Down Expand Up @@ -103,18 +102,6 @@ async def test_direct_debug_request(kernel):
assert reply["header"]["msg_type"] == "debug_reply"


async def test_deprecated_features(kernel):
with warnings.catch_warnings():
warnings.simplefilter("ignore", DeprecationWarning)
header = kernel._parent_header
assert isinstance(header, dict)
shell_streams = kernel.shell_streams
assert len(shell_streams) == 1
assert shell_streams[0] == kernel.shell_stream
warnings.simplefilter("ignore", RuntimeWarning)
kernel.shell_streams = [kernel.shell_stream, kernel.shell_stream]


async def test_process_control(kernel):
from jupyter_client.session import DELIM

Expand Down
Loading