Remove deprecated shell_streams and _parent_header shims#1504
Open
erikgaas wants to merge 3 commits intoipython:mainfrom
Open
Remove deprecated shell_streams and _parent_header shims#1504erikgaas wants to merge 3 commits intoipython:mainfrom
shell_streams and _parent_header shims#1504erikgaas wants to merge 3 commits intoipython:mainfrom
Conversation
shell_streams (plural) was deprecated in ipykernel 6.0 (2021) in favor of shell_stream (singular). Remove the trait, default handler, observer, and associated test.
for more information, see https://pre-commit.ci
erikgaas
changed the title
shell_streams shimshell_streams and _parent_header shims
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove two deprecated compatibility shims from ipykernel 6.0 (2021):
shell_streams(plural) — deprecated in favor ofshell_stream(singular)_parent_headerproperty — deprecated in favor ofget_parent()Both have been emitting
DeprecationWarningfor 5 years.Changes
shell_streamstrait,_shell_streams_default, and_shell_streams_changedfromkernelbase.py_parent_headerdeprecated property fromkernelbase.pytest_deprecated_featurestest that covered bothNo behavioral change —
shell_streamandget_parent()remain the supported APIs.