chore(SDBI-3897): Address security vulnerabilities associated with Va… #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdict. * Upgraded htsjdk to 3.0.5; this is not the latest available but the latest that does not carry compilation errors. * Upgraded additional transitive dependencies with vulnerabilities (ant, commons-compress and snappy-java) * Bumped version to 1.8.3.1 * Updated gradlew version to 6.9.3 as current one seems to be problematic to build a docker image. * Explicitly point to maven repository provoding url as the default seems to be problematic when building a docker image. * Deleted pre-builded release zip files.
vruano
force-pushed
the
SDBI-3897-address-vulnerabilities-vardict
branch
from
3a748a0 to
1308511
Compare
|
I would suggest not removing the Binary files as its going to make it harder to upstream any changes to the original repo. https://github.com/AstraZeneca-NGS/VarDictJava Since they still have the versions in the repo. |
Collaborator
Author
|
@TechIsCool Thanks. I rather keep it simple and leave as it is for now. If we do a pull request toward the original repo I'm ok with the additional work or even rather suggest to remove those earlier versions as in general is not a good idea hold on to them in the source code tree; they should we using some other tool to archive them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rdict.