Skip to content

Commit 1308511

Browse files
committed
chore(SDBI-3897): Address security vulnerabilities associated with Vardict.
* Upgraded htsjdk to 3.0.5; this is not the latest available but the latest that does not carry compilation errors. * Upgraded additional transitive dependencies with vulnerabilities (ant, commons-compress and snappy-java) * Bumped version to 1.8.3.1 * Updated gradlew version to 6.9.3 as current one seems to be problematic to build a docker image. * Explicitly point to maven repository provoding url as the default seems to be problematic when building a docker image. * Deleted pre-builded release zip files.
1 parent 0886261 commit 1308511

24 files changed

Lines changed: 23 additions & 5 deletions

Readme.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
[![Bioconda](https://img.shields.io/badge/install%20with-bioconda-brightgreen.svg?style=flat)](https://bioconda.github.io/recipes/vardict-java/README.html)
22
[![European Galaxy server](https://img.shields.io/badge/usegalaxy-.eu-brightgreen?logo=data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABgAAAASCAYAAABB7B6eAAAABGdBTUEAALGPC/xhBQAAACBjSFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACXBIWXMAAAsTAAALEwEAmpwYAAACC2lUWHRYTUw6Y29tLmFkb2JlLnhtcAAAAAAAPHg6eG1wbWV0YSB4bWxuczp4PSJhZG9iZTpuczptZXRhLyIgeDp4bXB0az0iWE1QIENvcmUgNS40LjAiPgogICA8cmRmOlJERiB4bWxuczpyZGY9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkvMDIvMjItcmRmLXN5bnRheC1ucyMiPgogICAgICA8cmRmOkRlc2NyaXB0aW9uIHJkZjphYm91dD0iIgogICAgICAgICAgICB4bWxuczp0aWZmPSJodHRwOi8vbnMuYWRvYmUuY29tL3RpZmYvMS4wLyI+CiAgICAgICAgIDx0aWZmOlJlc29sdXRpb25Vbml0PjI8L3RpZmY6UmVzb2x1dGlvblVuaXQ+CiAgICAgICAgIDx0aWZmOkNvbXByZXNzaW9uPjE8L3RpZmY6Q29tcHJlc3Npb24+CiAgICAgICAgIDx0aWZmOk9yaWVudGF0aW9uPjE8L3RpZmY6T3JpZW50YXRpb24+CiAgICAgICAgIDx0aWZmOlBob3RvbWV0cmljSW50ZXJwcmV0YXRpb24+MjwvdGlmZjpQaG90b21ldHJpY0ludGVycHJldGF0aW9uPgogICAgICA8L3JkZjpEZXNjcmlwdGlvbj4KICAgPC9yZGY6UkRGPgo8L3g6eG1wbWV0YT4KD0UqkwAAAn9JREFUOBGlVEuLE0EQruqZiftwDz4QYT1IYM8eFkHFw/4HYX+GB3/B4l/YP+CP8OBNTwpCwFMQXAQPKtnsg5nJZpKdni6/6kzHvAYDFtRUT71f3UwAEbkLch9ogQxcBwRKMfAnM1/CBwgrbxkgPAYqlBOy1jfovlaPsEiWPROZmqmZKKzOYCJb/AbdYLso9/9B6GppBRqCrjSYYaquZq20EUKAzVpjo1FzWRDVrNay6C/HDxT92wXrAVCH3ASqq5VqEtv1WZ13Mdwf8LFyyKECNbgHHAObWhScf4Wnj9CbQpPzWYU3UFoX3qkhlG8AY2BTQt5/EA7qaEPQsgGLWied0A8VKrHAsCC1eJ6EFoUd1v6GoPOaRAtDPViUr/wPzkIFV9AaAZGtYB568VyJfijV+ZBzlVZJ3W7XHB2RESGe4opXIGzRTdjcAupOK09RA6kzr1NTrTj7V1ugM4VgPGWEw+e39CxO6JUw5XhhKihmaDacU2GiR0Ohcc4cZ+Kq3AjlEnEeRSazLs6/9b/kh4eTC+hngE3QQD7Yyclxsrf3cpxsPXn+cFdenF9aqlBXMXaDiEyfyfawBz2RqC/O9WF1ysacOpytlUSoqNrtfbS642+4D4CS9V3xb4u8P/ACI4O810efRu6KsC0QnjHJGaq4IOGUjWTo/YDZDB3xSIxcGyNlWcTucb4T3in/3IaueNrZyX0lGOrWndstOr+w21UlVFokILjJLFhPukbVY8OmwNQ3nZgNJNmKDccusSb4UIe+gtkI+9/bSLJDjqn763f5CQ5TLApmICkqwR0QnUPKZFIUnoozWcQuRbC0Km02knj0tPYx63furGs3x/iPnz83zJDVNtdP3QAAAABJRU5ErkJggg==)](https://usegalaxy.eu/root?tool_id=vardict_java)
33

4-
> This is the Final Version of VarDict. No longer maintained.
4+
This is a forked Version based on the original VarDict-Java 1.8.3 (the latest release produced).
5+
The intent of this fork is *not* to add new functionalty but just to do some basic maintenance of otherwise no longer
6+
supported valuable piece of software. This encompasses fixing security vulnerabilities and perhaps fix some
7+
"show stopper" bugs as these araise.
58

69
# VarDictJava
710

build.gradle

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ plugins {
44
id 'jacoco'
55
}
66

7-
version = '1.8.3'
7+
version = '1.8.3.1'
88

99
repositories {
10-
mavenCentral()
10+
maven { url "https://repo.maven.apache.org/maven2" }
1111
}
1212

1313
targetCompatibility = "1.8"
@@ -25,11 +25,18 @@ dependencies {
2525
compile 'commons-cli:commons-cli:1.2'
2626
compile 'org.apache.commons:commons-math3:3.6.1'
2727
compile 'com.edropple.jregex:jregex:1.2_01'
28-
compile('com.github.samtools:htsjdk:2.21.1') {
28+
compile('com.github.samtools:htsjdk:3.0.5') {
2929
transitive = false
3030
}
31+
// explicit commons-compress and snappy-java depenencies to force the use ot vulnerability free
32+
// version of this packages.
33+
compile 'org.apache.commons:commons-compress:1.26.1'
34+
compile 'org.xerial.snappy:snappy-java:1.1.10.7'
35+
3136
testCompile 'org.mockito:mockito-core:2.23.0'
3237
testCompile 'org.testng:testng:6.9.13.6'
38+
// explicit ant dependency added to force upgrade to safe version for this testng dependency.
39+
testCompile 'org.apache.ant:ant:1.10.15'
3340
}
3441

3542
mainClassName = "com.astrazeneca.vardict.Main"

changelog.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
Version 1.8.3.1
2+
- Updated htsjdk dependency to 3.0.5
3+
- Upgrade transitive dependencies with vulneravilities to safe later versions:
4+
- org.apache.commons:commons-compress (-> 1.26.1)
5+
- org.xerial.snappy:snappy-java (-> 1.1.10.7)
6+
- org.apache.ant:ant (-> 1.10.15)
7+
- Deleted previous release binaries from source tree.
8+
19
Version 1.8.3
210
- Updated submodule and version.
311
- Fixed check for introns for the case when deletion is next to insertion.

dist/VarDict-1.2.2.zip

-1.29 MB
Binary file not shown.

dist/VarDict-1.2.4.zip

-1.29 MB
Binary file not shown.

dist/VarDict-1.3.zip

-1.3 MB
Binary file not shown.

dist/VarDict-1.4.1.zip

-1.3 MB
Binary file not shown.

dist/VarDict-1.4.2.zip

-1.33 MB
Binary file not shown.

dist/VarDict-1.4.3.zip

-1.33 MB
Binary file not shown.

dist/VarDict-1.4.4.zip

-1.33 MB
Binary file not shown.

0 commit comments

Comments
 (0)