Skip to content

fix: Bump ruff version and fix new errors #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
silasary wants to merge 2 commits into from
Closed

fix: Bump ruff version and fix new errors #1774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db521a6
fix: Fix new ruff errors
silasary May 22, 2025
a89de33
ci: correct from checks.
pre-commit-ci[bot] May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ repos:
- id: check-merge-conflict
name: Merge Conflicts
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: 'v0.4.3'
rev: 'v0.11.10'
Copy link

@AutonomousCat AutonomousCat Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev: 'v0.11.10'
rev: 'v0.14.6'

Copy link
Member Author

@silasary silasary Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you confirmed that we meet the expectations of v14?

I know this PR merges with v11. I am not convinced that's true for v14 with no other changes.

Copy link

@AutonomousCat AutonomousCat Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad I didn't realize I could only reference lines you changed using this review thing. Should've just made a PR

hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix]
Expand Down
Loading