-
Notifications
You must be signed in to change notification settings - Fork 185
fix: Bump ruff version and fix new errors #1774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## unstable #1774 +/- ##
============================================
+ Coverage 46.54% 46.58% +0.04%
============================================
Files 149 149
Lines 16454 16454
============================================
+ Hits 7658 7665 +7
+ Misses 8796 8789 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please may you re-base onto unstable::latest? |
| name: Merge Conflicts | ||
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| rev: 'v0.4.3' | ||
| rev: 'v0.11.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| rev: 'v0.11.10' | |
| rev: 'v0.14.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you confirmed that we meet the expectations of v14?
I know this PR merges with v11. I am not convinced that's true for v14 with no other changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad I didn't realize I could only reference lines you changed using this review thing. Should've just made a PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To bump from Ruff 0.11.10 to 0.14.6, it looks like the only thing that needs to be changed is resolving unused-unpacked-variable (RUF059) added in Ruff 0.13.0
My changes here:
|
Can I get you to open that as a PR? |
Pull Request Type
Description
Changes
Related Issues
Test Scenarios
Python Compatibility
3.10.x3.11.xChecklist
pre-commitcode linter over all edited files