Skip to content

Conversation

@silasary
Copy link
Member

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Changes

Related Issues

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.58%. Comparing base (4dc1764) to head (fef98ed).

Files with missing lines Patch % Lines
interactions/ext/prefixed_commands/command.py 0.00% 3 Missing ⚠️
interactions/ext/sentry.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1774      +/-   ##
============================================
+ Coverage     46.54%   46.58%   +0.04%     
============================================
  Files           149      149              
  Lines         16454    16454              
============================================
+ Hits           7658     7665       +7     
+ Misses         8796     8789       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LordOfPolls
Copy link
Contributor

Please may you re-base onto unstable::latest?

name: Merge Conflicts
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: 'v0.4.3'
rev: 'v0.11.10'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev: 'v0.11.10'
rev: 'v0.14.6'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you confirmed that we meet the expectations of v14?

I know this PR merges with v11. I am not convinced that's true for v14 with no other changes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad I didn't realize I could only reference lines you changed using this review thing. Should've just made a PR

Copy link

@AutonomousCat AutonomousCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To bump from Ruff 0.11.10 to 0.14.6, it looks like the only thing that needs to be changed is resolving unused-unpacked-variable (RUF059) added in Ruff 0.13.0

My changes here:

@silasary
Copy link
Member Author

Can I get you to open that as a PR?

@silasary silasary closed this Nov 24, 2025
@silasary silasary deleted the ruff-v11 branch November 30, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants