[SYCL] Implement structs that contains special types as parameters to free function kernels #20844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ushi25/llvm into struct_contains_special_types
…ushi25/llvm into struct_contains_special_types
…ushi25/llvm into struct_contains_special_types
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
lbushi25
commented
Dec 5, 2025
| // CHECK-NEXT: { kernel_param_kind_t::kind_pointer, 8, 0 }, | ||
| // CHECK-NEXT: { kernel_param_kind_t::kind_std_layout, 4, 8 }, | ||
| // CHECK-NEXT: { kernel_param_kind_t::kind_std_layout, 4, 12 }, | ||
| // CHECK-NEXT: { kernel_param_kind_t::kind_std_layout, 4, 0 }, |
Contributor
Author
There was a problem hiding this comment.
@premanandrao Regarding these changes...
The offsets for arguments of a free function kernel are somewhat meaningless since there is no concept of a closure class as is the case with lambda kernels. Therefore, I think it's less confusing to simply give them an offset of zero and reserve non-zero offsets for the fields inside a parameter struct which will help us find them in the runtime layer. So, all of these zeros are simply offsets of top-level parameters for which a non-zero offset does not make sense in the context of free function kernels.
Contributor
Author
There was a problem hiding this comment.
@premanandrao Also, your other suggestions in #18692 have been applied including the unused function.
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for structs containing special types as free function kernel parameters.