[SYCL] Add support for structs containing special types as free function kernel parameters #18692

lbushi25 · 2025-05-28T02:14:52Z

Add support for structs containing special types as free function kernel parameters.

clang/lib/Sema/SemaSYCL.cpp

…ushi25/llvm into struct_contains_special_types

premanandrao · 2025-12-05T18:06:12Z

clang/lib/Sema/SemaSYCL.cpp

-    // TODO
-    unsupportedFreeFunctionParamType();
+  bool enterStruct(const CXXRecordDecl *, ParmVarDecl *,
+                   QualType ParamTy) final {


Suggested change

QualType ParamTy) final {

QualType) final {

Since it is not used.

premanandrao · 2025-12-05T18:06:35Z

clang/lib/Sema/SemaSYCL.cpp

+  bool leaveStruct(const CXXRecordDecl *, ParmVarDecl *PD,
+                   QualType ParamTy) final {


Suggested change

bool leaveStruct(const CXXRecordDecl *, ParmVarDecl *PD,

QualType ParamTy) final {

bool leaveStruct(const CXXRecordDecl *, ParmVarDecl *,

QualType) final {

premanandrao · 2025-12-05T18:06:51Z

clang/lib/Sema/SemaSYCL.cpp

-  bool handleScalarType(ParmVarDecl *, QualType) final {
-    // TODO
-    unsupportedFreeFunctionParamType();
+  bool handleScalarType(ParmVarDecl *PD, QualType ParamTy) final {


Suggested change

bool handleScalarType(ParmVarDecl *PD, QualType ParamTy) final {

bool handleScalarType(ParmVarDecl *, QualType) final {

premanandrao · 2025-12-05T18:07:08Z

clang/lib/Sema/SemaSYCL.cpp

+  bool handleNonDecompStruct(const CXXRecordDecl *, ParmVarDecl *PD,
+                             QualType ParamTy) final {


Suggested change

bool handleNonDecompStruct(const CXXRecordDecl *, ParmVarDecl *PD,

QualType ParamTy) final {

bool handleNonDecompStruct(const CXXRecordDecl *, ParmVarDecl *,

QualType) final {

premanandrao · 2025-12-05T18:07:23Z

clang/lib/Sema/SemaSYCL.cpp

-  bool enterStruct(const CXXRecordDecl *, ParmVarDecl *, QualType) final {
-    // TODO
-    // ++StructDepth;
+  bool enterStruct(const CXXRecordDecl *, ParmVarDecl *PD, QualType Ty) final {


Suggested change

bool enterStruct(const CXXRecordDecl *, ParmVarDecl *PD, QualType Ty) final {

bool enterStruct(const CXXRecordDecl *, ParmVarDecl *, QualType Ty) final {

premanandrao · 2025-12-05T18:35:01Z

clang/lib/Sema/SemaSYCL.cpp

-  bool leaveStruct(const CXXRecordDecl *, FieldDecl *, QualType) final {
-    // TODO
-    unsupportedFreeFunctionParamType();
+  bool leaveStruct(const CXXRecordDecl *, FieldDecl *FD, QualType Ty) final {


Suggested change

bool leaveStruct(const CXXRecordDecl *, FieldDecl *FD, QualType Ty) final {

bool leaveStruct(const CXXRecordDecl *, FieldDecl *, QualType) final {

premanandrao · 2025-12-05T18:36:20Z

clang/lib/Sema/SemaSYCL.cpp

+    assert(CurrentStructs.size() &&
+           "Current free function parameter is not inside a structure!");
+    return CurrentStructs.back();
+  }


Is this function used anywhere?

premanandrao · 2025-12-05T18:44:13Z

clang/lib/Sema/SemaSYCL.cpp

+
+      FwdDeclEmitter.Visit(type.getDesugaredType(S.getASTContext()));
+
+      // this is a struct that contains a special type so its neither a


Suggested change

// this is a struct that contains a special type so its neither a

// This is a struct that contains a special type so it's neither a

clang/lib/Sema/SemaSYCL.cpp

premanandrao · 2025-12-05T18:58:55Z

clang/test/CodeGenSYCL/free_function_int_header.cpp

 // CHECK-NEXT:   { kernel_param_kind_t::kind_pointer, 8, 0 },
-// CHECK-NEXT:   { kernel_param_kind_t::kind_std_layout, 4, 8 },
-// CHECK-NEXT:   { kernel_param_kind_t::kind_std_layout, 4, 12 },
+// CHECK-NEXT:   { kernel_param_kind_t::kind_std_layout, 4, 0 },


Can you please explain the changes to the offsets (i.e. previous value to 0) in this test?

lbushi25 · 2025-12-05T19:01:10Z

I seem to have added a lot of unneeded reviewers due to a dirty local repository. Please ignore this PR, only @intel/dpcpp-cfe-reviewers are relevant here.

Co-authored-by: premanandrao <premanand.m.rao@intel.com>

This reverts commit befc6a1.

lbushi25 · 2025-12-05T19:26:37Z

@premanandrao please head over to #20844 as I'm closing this as the commit history has been completely messed up. I will address your review there instead.

lbushi25 added 2 commits May 27, 2025 19:10

Provide supports for decomposable structs

34a11ca

Merge branch 'sycl' of https://github.com/lbushi25/llvm into sycl

edec2b4

lbushi25 had a problem deploying to WindowsCILock May 28, 2025 02:15 — with GitHub Actions Failure

lbushi25 changed the title ~~[SYCL] Struct contains special types~~ [SYCL] Add support for structs containing special types as free function kernel parameters May 28, 2025

lbushi25 had a problem deploying to WindowsCILock May 28, 2025 02:39 — with GitHub Actions Failure

AlexeySachkov reviewed May 28, 2025

View reviewed changes

clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved

Remove debugging statements and apply clang-format

c87f239

lbushi25 had a problem deploying to WindowsCILock May 28, 2025 14:48 — with GitHub Actions Error

Remove debugging statements and apply clang-format

6255cf2

lbushi25 had a problem deploying to WindowsCILock May 28, 2025 14:48 — with GitHub Actions Error

Remove debugging statements and apply clang-format

4de6a52

lbushi25 had a problem deploying to WindowsCILock May 28, 2025 14:49 — with GitHub Actions Error

Remove TODO statements from code

5800d46

lbushi25 had a problem deploying to WindowsCILock May 28, 2025 14:51 — with GitHub Actions Failure

lbushi25 had a problem deploying to WindowsCILock May 28, 2025 15:25 — with GitHub Actions Failure

lbushi25 added 4 commits June 3, 2025 11:45

Wrapped speaicl types support

d1d43f1

Merge branch 'struct_contains_special_types' of https://github.com/lb…

960ff52

…ushi25/llvm into struct_contains_special_types

Test

290288c

Merge branch 'sycl' into struct_contains_special_types

9e90792

lbushi25 had a problem deploying to WindowsCILock July 11, 2025 17:15 — with GitHub Actions Failure

lbushi25 had a problem deploying to WindowsCILock July 11, 2025 17:46 — with GitHub Actions Failure

Fix offsets in integration header

5a2faea

lbushi25 had a problem deploying to WindowsCILock July 16, 2025 20:00 — with GitHub Actions Error

Fix offsets in integration header

dcac442

lbushi25 had a problem deploying to WindowsCILock July 16, 2025 20:01 — with GitHub Actions Failure

Merge branch 'intel:sycl' into struct_contains_special_types

257c9c3

lbushi25 had a problem deploying to WindowsCILock July 17, 2025 14:28 — with GitHub Actions Error

lbushi25 requested review from a team and bader as code owners December 5, 2025 18:58

lbushi25 requested a review from mmichel11 December 5, 2025 18:58

lbushi25 had a problem deploying to WindowsCILock December 5, 2025 18:58 — with GitHub Actions Error

premanandrao reviewed Dec 5, 2025

View reviewed changes

lbushi25 had a problem deploying to WindowsCILock December 5, 2025 18:59 — with GitHub Actions Error

Update clang/lib/Sema/SemaSYCL.cpp

a5c6090

Co-authored-by: premanandrao <premanand.m.rao@intel.com>

lbushi25 had a problem deploying to WindowsCILock December 5, 2025 19:03 — with GitHub Actions Error

Revert "Update Windows ABI symbols"

ebce536

This reverts commit befc6a1.

lbushi25 had a problem deploying to WindowsCILock December 5, 2025 19:05 — with GitHub Actions Failure

lbushi25 had a problem deploying to WindowsCILock December 5, 2025 19:06 — with GitHub Actions Failure

lbushi25 closed this Dec 5, 2025

lbushi25 temporarily deployed to WindowsCILock December 5, 2025 19:33 — with GitHub Actions Inactive

lbushi25 temporarily deployed to WindowsCILock December 5, 2025 19:49 — with GitHub Actions Inactive

lbushi25 mentioned this pull request Dec 5, 2025

[SYCL] Implement structs that contains special types as parameters to free function kernels #20844

Open

		bool leaveStruct(const CXXRecordDecl , ParmVarDecl PD,
		QualType ParamTy) final {

	bool handleScalarType(ParmVarDecl *PD, QualType ParamTy) final {
	bool handleScalarType(ParmVarDecl *, QualType) final {

		bool handleNonDecompStruct(const CXXRecordDecl , ParmVarDecl PD,
		QualType ParamTy) final {

	bool enterStruct(const CXXRecordDecl , ParmVarDecl PD, QualType Ty) final {
	bool enterStruct(const CXXRecordDecl , ParmVarDecl , QualType Ty) final {


		FwdDeclEmitter.Visit(type.getDesugaredType(S.getASTContext()));

		// this is a struct that contains a special type so its neither a

[SYCL] Add support for structs containing special types as free function kernel parameters #18692

[SYCL] Add support for structs containing special types as free function kernel parameters #18692

Uh oh!

Conversation

lbushi25 commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lbushi25 commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lbushi25 commented Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

lbushi25 commented May 28, 2025 •

edited

Loading

lbushi25 commented Dec 5, 2025 •

edited

Loading