Document explicitly that events can be posted twice, SIMICS-23394#413
Open
mandolaerik wants to merge 3 commits intointel:mainfrom
Open
Conversation
Contributor
|
PR Verification: ✅ success |
lwaern-intel
requested changes
Feb 17, 2026
| `event` callback from the previous call has been invoked; in this case, the | ||
| `event` callback will be invoked twice. In the `uint64_*_event` and | ||
| `custom_*_event` cases, the event data may or may not be identical between the | ||
| two calls. |
Contributor
There was a problem hiding this comment.
I think you should reference remove() parenthetically here:
... , and hence
remove()may cancel only one pending callback but not the other.
Contributor
Author
There was a problem hiding this comment.
Except that we haven't mentioned remove yet. I can add a note to remove.
mandolaerik
force-pushed
the
pr/document-explicitly-that-events-can-be-posted-twice-simics-23394
branch
from
156c070 to
abf7247
Compare
Contributor
|
PR Verification: ✅ success |
Contributor
|
PR Verification: ✅ success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.