Skip to content

Promote after:, SIMICS-23393#414

Open
mandolaerik wants to merge 1 commit intointel:mainfrom
mandolaerik:pr/promote-after-simics-23393
Open

Promote after:, SIMICS-23393#414
mandolaerik wants to merge 1 commit intointel:mainfrom
mandolaerik:pr/promote-after-simics-23393

Conversation

@mandolaerik
Copy link
Contributor

No description provided.

@syssimics
Copy link
Contributor

PR Verification: ✅ success


In Simics, the `after` event is posted on the clock or CPU associated with the
device. This is not necessarily the same as the currently executing CPU. This
means that a significant number of CPU instructions might be executed before
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency: CPU vs. processor? We should pick one term and stick with it. I've been using "processor." The Simics API docs aren't consistent about this, by the by, they use "CPU", "processor", and "executor" interchangeably.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it seems that most uses of "processor" relate to the aspect defined by processor_info_v2, i.e. a thing that can interpret memory contents as instructions; this makes some inspection and debugging facilities interesting. Whereas "clock" or "queue" is a term specifically related to driving the simulation and interacting with the scheduler. IIRC, I have only encountered "executor" as an internal term related to scheduling.

The term CPU seems more popular, e.g. src/cpu and conf.cpu0, and my intent here was to sloppily say CPU instead of clock because it's easier to relate to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the inconsistency by changing processor->CPU in some places, but accidentally pushed this to #413 instead. If you object to those changes, then please keep the discussion on this thread and I'll move patches where they belong. If you don't, then I'll just merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants