Add support for finance_account in feedback API

README.md

@@ -23,14 +23,14 @@ And then add the artifact `incognia-api-client` **or** `incognia-api-client-shad
 <dependency>
   <groupId>com.incognia</groupId>
   <artifactId>incognia-api-client</artifactId>
-  <version>3.14.0</version>
+  <version>3.15.0</version>
 </dependency>
 ```
 ```xml
 <dependency>
   <groupId>com.incognia</groupId>
   <artifactId>incognia-api-client-shaded</artifactId>
-  <version>3.14.0</version>
+  <version>3.15.0</version>
 </dependency>
 ```
 
@@ -47,13 +47,13 @@ repositories {
 And then add the dependency
 ```gradle
 dependencies {
-     implementation 'com.incognia:incognia-api-client:3.14.0'
+     implementation 'com.incognia:incognia-api-client:3.15.0'
 }
 ```
 OR
 ```gradle
 dependencies {
-     implementation 'com.incognia:incognia-api-client-shaded:3.14.0'
+     implementation 'com.incognia:incognia-api-client-shaded:3.15.0'
 }
 ```
 

build.gradle

@@ -8,7 +8,7 @@ plugins {
 }
 
 group = "com.incognia"
-version = "3.14.0"
+version = "3.15.0"
 
 task createProjectVersionFile {
     def projectVersionDir = "$projectDir/src/main/java/com/incognia/api"

src/main/java/com/incognia/api/IncogniaAPI.java

@@ -543,6 +543,7 @@ public void registerFeedback(
             .externalId(identifiers.getExternalId())
             .requestToken(identifiers.getRequestToken())
             .personId(identifiers.getPersonId())
+            .financialAccount(identifiers.getFinancialAccount())
             .expiresAt(
                 Optional.ofNullable(identifiers.getExpiresAt()).map(Instant::toString).orElse(null))
             .build();

src/main/java/com/incognia/common/HolderTaxID.java

@@ -0,0 +1,27 @@
+package com.incognia.common;
+
+import lombok.Builder;
+import lombok.Value;
+
+@Value
+@Builder
+public class HolderTaxID implements TypedValue {
+  String type;
+  String value;
+
+  public static HolderTaxID ofCPF(String cpfValue) {
+    return HolderTaxID.builder().type("cpf").value(cpfValue).build();
+  }
+
+  public static HolderTaxID ofSSN(String ssnValue) {
+    return HolderTaxID.builder().type("ssn").value(ssnValue).build();
+  }
+
+  public static HolderTaxID ofEIN(String einValue) {
+    return HolderTaxID.builder().type("ein").value(einValue).build();
+  }
+
+  public static HolderTaxID ofCNPJ(String cnpjValue) {
+    return HolderTaxID.builder().type("cnpj").value(cnpjValue).build();
+  }
+}

src/main/java/com/incognia/common/PersonID.java

@@ -5,9 +5,9 @@
 
 @Value
 @Builder
-public class PersonID {
+public class PersonID implements TypedValue {
   String type;
   String value;
 
   public static PersonID ofCPF(String cpfValue) {
     return PersonID.builder().type("cpf").value(cpfValue).build();

src/main/java/com/incognia/common/TypedValue.java

@@ -0,0 +1,7 @@
+package com.incognia.common;
+
+public interface TypedValue {
+  String getType();
+
+  String getValue();
+}

src/main/java/com/incognia/feedback/FeedbackIdentifiers.java

@@ -1,6 +1,7 @@
 package com.incognia.feedback;
 
 import com.incognia.common.PersonID;
+import com.incognia.transaction.payment.BankAccountInfo;
 import java.time.Instant;
 import lombok.Builder;
 import lombok.Value;
@@ -18,4 +19,5 @@ public class FeedbackIdentifiers {
   String externalId;
   Instant expiresAt;
   PersonID personId;
+  BankAccountInfo financialAccount;
 }

src/main/java/com/incognia/feedback/PostFeedbackRequestBody.java

@@ -1,6 +1,7 @@
 package com.incognia.feedback;
 
 import com.incognia.common.PersonID;
+import com.incognia.transaction.payment.BankAccountInfo;
 import lombok.Builder;
 import lombok.Value;
 
@@ -19,4 +20,5 @@ public class PostFeedbackRequestBody {
   String signupId;
   String expiresAt;
   PersonID personId;
+  BankAccountInfo financialAccount;
 }

src/main/java/com/incognia/transaction/payment/BankAccountInfo.java

@@ -1,6 +1,6 @@
 package com.incognia.transaction.payment;
 
-import com.incognia.common.PersonID;
+import com.incognia.common.HolderTaxID;
 import java.util.Collections;
 import java.util.List;
 import lombok.Builder;
@@ -12,7 +12,7 @@ public class BankAccountInfo {
   String accountType;
   String accountPurpose;
   String holderType;
-  PersonID holderTaxId;
+  HolderTaxID holderTaxId;
   String country;
   String ispbCode;
   String branchCode;

src/test/java/com/incognia/api/IncogniaAPITest.java

@@ -13,6 +13,7 @@
 import com.incognia.api.clients.TokenAwareDispatcher;
 import com.incognia.common.Address;
 import com.incognia.common.Coordinates;
+import com.incognia.common.HolderTaxID;
 import com.incognia.common.Location;
 import com.incognia.common.PersonID;
 import com.incognia.common.Reason;
@@ -835,7 +836,7 @@ void testRegisterPayment_whenDataIsValid(Boolean eval) {
             .accountType("checking")
             .accountPurpose("general")
             .holderType("individual")
-            .holderTaxId(PersonID.builder().type("cpf").value("12345678901").build())
+            .holderTaxId(HolderTaxID.builder().type("cpf").value("12345678901").build())
             .country("BR")
             .ispbCode("12345678")
             .branchCode("0000")
@@ -983,6 +984,14 @@ void testRegisterFeedback_whenDataIsValid(boolean dryRun) {
     String signupId = UUID.randomUUID().toString();
     Instant timestamp = Instant.now();
     PersonID personId = PersonID.ofCPF("12345678901");
+    HolderTaxID holderTaxID = HolderTaxID.ofCPF("12345678901");
+    BankAccountInfo financialAccount =
+        BankAccountInfo.builder()
+            .accountNumber("123456")
+            .branchCode("1234")
+            .holderTaxId(holderTaxID)
+            .holderType("individual")
+            .build();
 
     dispatcher.setExpectedFeedbackRequestBody(
         PostFeedbackRequestBody.builder()
@@ -993,6 +1002,7 @@ void testRegisterFeedback_whenDataIsValid(boolean dryRun) {
             .event(FeedbackEvent.ACCOUNT_TAKEOVER)
             .timestamp(timestamp.toEpochMilli())
             .personId(personId)
+            .financialAccount(financialAccount)
             .build());
     mockServer.setDispatcher(dispatcher);
     client.registerFeedback(
@@ -1004,6 +1014,7 @@ void testRegisterFeedback_whenDataIsValid(boolean dryRun) {
             .externalId(externalId)
             .signupId(signupId)
             .personId(personId)
+            .financialAccount(financialAccount)
             .build(),
         dryRun);
   }