Add support for finance_account in feedback API#337
Closed
brunoekferrari wants to merge 7 commits intomasterfrom
Closed
Add support for finance_account in feedback API#337brunoekferrari wants to merge 7 commits intomasterfrom
brunoekferrari wants to merge 7 commits intomasterfrom
Conversation
brunoekferrari
changed the title
brunoekferrari
force-pushed
the
feat/add-financial-account-field
branch
2 times, most recently
from
178f634 to
fa61b06
Compare
brunoekferrari
force-pushed
the
feat/add-financial-account-field
branch
from
fa61b06 to
72812ce
Compare
brunoekferrari
force-pushed
the
feat/add-financial-account-field
branch
from
fe72dc2 to
0b9433b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
brunoekferrari
force-pushed
the
feat/add-financial-account-field
branch
from
0b9433b to
3089467
Compare
brunoekferrari
force-pushed
the
feat/add-financial-account-field
branch
from
3089467 to
bcaaa49
Compare
brunoekferrari
force-pushed
the
feat/add-financial-account-field
branch
from
b533d1f to
77ced2d
Compare
edenalsant
reviewed
Mar 10, 2026
Comment on lines
+16
to
+25
| public static HolderTaxID ofSSN(String ssnValue) { | ||
| return HolderTaxID.builder().type("ssn").value(ssnValue).build(); | ||
| } | ||
|
|
||
| public static HolderTaxID ofEIN(String einValue) { | ||
| return HolderTaxID.builder().type("ein").value(einValue).build(); | ||
| } | ||
|
|
||
| public static HolderTaxID ofCNPJ(String cnpjValue) { | ||
| return HolderTaxID.builder().type("cnpj").value(cnpjValue).build(); |
Contributor
There was a problem hiding this comment.
why were these methods created? they're not being used
Contributor
Author
There was a problem hiding this comment.
They are facilitators for the usage of each of these identifiers. We already had them for CPF and I added for the other ones to maintain the pattern.
edenalsant
reviewed
Mar 10, 2026
Contributor
There was a problem hiding this comment.
I'd remove this interface
edenalsant
reviewed
Mar 10, 2026
| String accountPurpose; | ||
| String holderType; | ||
| PersonID holderTaxId; | ||
| HolderTaxID holderTaxId; |
Contributor
There was a problem hiding this comment.
this is a breaking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds support for sending the financial_account object in the Feedback API.
The Feedback endpoint now allows additional financial account information to be included when reporting fraud events. This change introduces the necessary models and updates the feedback request body so that financial_account can be optionally provided when calling registerFeedback.
Checklist