Conversation
This reverts commit 8881c34.
|
Hey @phamalis this looks good, please schedule some time with me this week so we can create/use redux selectors to get the real data. |
|
@phamalis Can you push your latest changes, and address the merge conflicts. What's the latest on this? |
…plate into ieee-255-overview git commit -m 'merge because pycharm asked me to pull before push, new update allows overview section to update with real data'
danielqiuu
left a comment
danielqiuu
left a comment
There was a problem hiding this comment.
Seems like Alisha has implemented a few selectors (which were outside the scope of this ticket/pr). This page is still missing the selector that fetches the number of broken/lost items. Which should probably be implemented in another ticket (since this one focuses on ui)
| @@ -205,4 +205,29 @@ export const adminOrderTotalSelector = createSelector( | |||
| (orderItems) => orderItems.reduce((accum) => accum + 1, 0) | |||
There was a problem hiding this comment.
Please change name of adminOrderTotalSelector to 'adminOrderTotalWithFiltersSelector', or similar.
| (orderItems) => orderItems.reduce((accum) => accum + 1, 0) | ||
| ); | ||
|
|
||
| export const adminOrderNewTotalSelector = createSelector( |
There was a problem hiding this comment.
get rid of 'new' in naming
…ot impacted by filters
4 participants
Overview
Resolves 255
Created the Overview Section composed of cards that shows total number of
Unit Tests Created
Steps to QA