Closed
Conversation
Mustaballer
requested changes
Jun 18, 2023
Contributor
Mustaballer
left a comment
Mustaballer
left a comment
There was a problem hiding this comment.
Hey @phamalis we don't want to be deleting the yarn.lock file since it already exists, can you undo deleting it and make sure its the same as before(if it is, git will not include in this PR). Please do the same for the package.json --> we should not be commiting that file at all in this PR.
You can schedule some time with me this week and we can go over the cool stuff --> using real data instead with redux.
…thon-template into ieee-255-overview-section
Contributor
|
Closed in favour of #504 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Unit Tests Created
Steps to QA