fix(vordr): commit Cargo.lock for reproducible builds (closes #14)#19
Merged
Conversation
Closes #14. The Containerfile expects Cargo.lock alongside Cargo.toml; it wasn't committed because the repo's .gitignore broadly excludes Cargo.lock (library-crate convention). For BINARY crates (vordr is a CLI binary) the lockfile should be tracked so deployments are reproducible. Force-added via `git add -f` to bypass the .gitignore rule. A cleaner follow-up would be to add a .gitignore exception: !container-stack/vordr/src/rust/Cargo.lock or move vordr-specific .gitignore rules into a per-crate .gitignore.
|
hyperpolymath
added a commit
that referenced
this pull request
May 3, 2026
This reverts commit 4dcb75a.
hyperpolymath
added a commit
that referenced
this pull request
May 3, 2026
Closes #14. The Containerfile expects Cargo.lock alongside Cargo.toml; it wasn't committed because the repo's .gitignore broadly excludes Cargo.lock (library-crate convention). For BINARY crates (vordr is a CLI binary) the lockfile should be tracked so deployments are reproducible. Force-added via `git add -f` to bypass the .gitignore rule. A cleaner follow-up would be to add a .gitignore exception: !container-stack/vordr/src/rust/Cargo.lock or move vordr-specific .gitignore rules into a per-crate .gitignore.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The vordr Containerfile expects
Cargo.lockalongsideCargo.tomlbut it was not committed. Closes #14.Change
Force-added
container-stack/vordr/src/rust/Cargo.lock(96KB, ~190 transitive deps), generated viacargo generate-lockfileagainst the existing Cargo.toml.Why force-add
The repo has conflicting .gitignore signals:
.gitignore:# Cargo.lock # Keep for binaries(commented out — i.e. NOT ignored)container-stack/vordr/.gitignoreline 15:Cargo.lock(ignored)container-stack/vordr/src/rust/.gitignoreline 3:Cargo.lock(ignored)The per-crate ignores override. For a binary crate (vordr is a CLI binary), Cargo's recommendation is to track Cargo.lock so deployments are reproducible. The top-level comment shows that intent.
A clean follow-up would remove the
Cargo.lockline from the per-crate .gitignores, or add!container-stack/vordr/src/rust/Cargo.lockas an explicit exception. This PR keeps scope tight and just adds the lockfile.Test plan
cargo generate-lockfileruns cleanly against current Cargo.tomlCross-reference: idaptik issue hyperpolymath/idaptik@98f110ce filed this.