fix(vordr): commit Cargo.lock for reproducible builds (re-apply, closes #14)#22
Merged
Merged
Conversation
Closes #14. The Containerfile expects Cargo.lock alongside Cargo.toml; it wasn't committed because the repo's .gitignore broadly excludes Cargo.lock (library-crate convention). For BINARY crates (vordr is a CLI binary) the lockfile should be tracked so deployments are reproducible. Force-added via `git add -f` to bypass the .gitignore rule. A cleaner follow-up would be to add a .gitignore exception: !container-stack/vordr/src/rust/Cargo.lock or move vordr-specific .gitignore rules into a per-crate .gitignore.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies fix originally squash-merged as #19 and reverted as part of the rescript-ecosystem cleanup. Same content. Closes #14.
Containerfile expects Cargo.lock alongside Cargo.toml; .gitignore was previously hiding it. Force-added so binary-crate builds are reproducible.