Skip to content

fix: address copilot feedback on urunc image #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danbugs merged 2 commits into from
Jun 3, 2026
Merged

fix: address copilot feedback on urunc image #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31c0922
fix: add .dockerignore to reduce urunc build context size
danbugs Jun 3, 2026
fdd639e
fix: grammar nit in URUNC.md
danbugs Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions examples/helloworld-c/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
.unikraft/unikraft
.unikraft/apps
.unikraft/libs
.unikraft/build/config
.unikraft/build/kconfig
.unikraft/build/lib*
.unikraft/build/Makefile
.unikraft/build/*.cmd
.unikraft/build/*.py
.unikraft/build/*.o
.unikraft/build/*.dbg*
.unikraft/build/*.bootinfo*
.unikraft/build/include
.unikraft/build/appelfloader*
.unikraft/build/provided_syscalls*
.unikraft/build/libraries*
hello
2 changes: 1 addition & 1 deletion examples/helloworld-c/URUNC.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ The OCI image contains just three files:
- `/unikernel/initrd.cpio` — CPIO archive containing `/bin/hello` (static-PIE C binary)
- `/urunc.json` — urunc annotations identifying this as a `hyperlight` + `unikraft` workload

When urunc runs the image, it finds `hyperlight-unikraft` on the host, bind-mounts it along with `/dev/kvm` into an isolated rootfs, and exec's:
When urunc runs the image, it finds `hyperlight-unikraft` on the host, bind-mounts it along with `/dev/kvm` into an isolated rootfs, and execs:

```
hyperlight-unikraft /unikernel/kernel --initrd /unikernel/initrd.cpio --memory <bytes>
Expand Down
Loading