fix: address copilot feedback on urunc image#90
Merged
Conversation
Signed-off-by: danbugs <danilochiarlone@gmail.com>
Signed-off-by: danbugs <danilochiarlone@gmail.com>
There was a problem hiding this comment.
Pull request overview
Follow-up to PR #89 to address prior review feedback for the examples/helloworld-c urunc OCI image packaging by reducing Docker build context size and correcting documentation grammar.
Changes:
- Add
examples/helloworld-c/.dockerignoreto exclude large local.unikraft/source/build artifacts from the Docker build context while still allowing the built kernel artifact to be copied into the image. - Fix grammar in
examples/helloworld-c/URUNC.md(“exec's” → “execs”).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/helloworld-c/URUNC.md | Corrects grammar in the urunc execution description. |
| examples/helloworld-c/.dockerignore | Reduces Docker build context size by ignoring generated Unikraft artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Linux Benchmarks
Details
| Benchmark suite | Current: fdd639e | Previous: f51e9da | Ratio |
|---|---|---|---|
hello_world (median) |
20 ms |
20 ms |
1 |
pandas (median) |
90 ms |
110 ms |
0.82 |
density (per VM) |
11 MB |
11 MB |
1 |
snapshot (disk) |
656 MiB |
656 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Windows Benchmarks
Details
| Benchmark suite | Current: fdd639e | Previous: f51e9da | Ratio |
|---|---|---|---|
hello_world (median) |
244 ms |
294 ms |
0.83 |
pandas (median) |
642 ms |
749 ms |
0.86 |
density (per VM) |
656 MB |
656 MB |
1 |
snapshot (disk) |
664 MiB |
664 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #89. Addresses two valid Copilot review comments:
.dockerignoretoexamples/helloworld-c/to exclude.unikraft/source/build artifacts from the Docker build context (was sending ~280MB unnecessarily)URUNC.mdSkipped the
sudo mvsuggestion for kraft-hyperlight install — the existingpublish-kernelsjob in the same workflow uses the same direct-write pattern and works fine.