Skip to content

Create connections with gRPC APIs in e2e tests#238

Merged
bestbeforetoday merged 1 commit intohyperledger:mainfrom
bestbeforetoday:grpc-connections
Mar 12, 2026
Merged

Create connections with gRPC APIs in e2e tests#238
bestbeforetoday merged 1 commit intohyperledger:mainfrom
bestbeforetoday:grpc-connections

Conversation

@bestbeforetoday
Copy link
Member

The helper functions in the network package provide complex implementations to create gRPC connections based on historic internal implementation of Fabric, which do not allow client code access to all of the configuration options available in the gRPC API.

This change updates the end-to-end tests to use the gRPC APIs directly to create connections. This demonstrates that client code can access the full configuration capability when creating gRPC connections without significantly more complexity.

@bestbeforetoday bestbeforetoday marked this pull request as ready for review March 12, 2026 10:26
@bestbeforetoday bestbeforetoday enabled auto-merge (squash) March 12, 2026 10:26
@bestbeforetoday bestbeforetoday force-pushed the grpc-connections branch 2 times, most recently from ae4e959 to af86447 Compare March 12, 2026 10:36
The helper functions in the network package provide complex
implementations to create gRPC connections based on historic internal
implementation of Fabric, which do not allow client code access to all
of the configuration options available in the gRPC API.

This change updates the end-to-end tests to use the gRPC APIs directly
to create connections. This demonstrates that client code can access the
full configuration capability when creating gRPC connections without
significantly more complexity.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Copy link
Contributor

@SamYuan1990 SamYuan1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bestbeforetoday bestbeforetoday merged commit 522592e into hyperledger:main Mar 12, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants