Create connections with gRPC APIs in e2e tests#238
Merged
bestbeforetoday merged 1 commit intohyperledger:mainfrom Mar 12, 2026
Merged
Create connections with gRPC APIs in e2e tests#238bestbeforetoday merged 1 commit intohyperledger:mainfrom
bestbeforetoday merged 1 commit intohyperledger:mainfrom
Conversation
ae4e959 to
af86447
Compare
The helper functions in the network package provide complex implementations to create gRPC connections based on historic internal implementation of Fabric, which do not allow client code access to all of the configuration options available in the gRPC API. This change updates the end-to-end tests to use the gRPC APIs directly to create connections. This demonstrates that client code can access the full configuration capability when creating gRPC connections without significantly more complexity. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
af86447 to
cc3faf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helper functions in the network package provide complex implementations to create gRPC connections based on historic internal implementation of Fabric, which do not allow client code access to all of the configuration options available in the gRPC API.
This change updates the end-to-end tests to use the gRPC APIs directly to create connections. This demonstrates that client code can access the full configuration capability when creating gRPC connections without significantly more complexity.