fix: do not set InsecureSkipVerify on TLS config#237
Merged
bestbeforetoday merged 1 commit intohyperledger:mainfrom Mar 11, 2026
Merged
fix: do not set InsecureSkipVerify on TLS config#237bestbeforetoday merged 1 commit intohyperledger:mainfrom
bestbeforetoday merged 1 commit intohyperledger:mainfrom
Conversation
The network.DialConnection function explicitly set InsecureSkipVerify to true on the tls.Config used to create gRPC connections. This change removes that behaviour, leaving TLS certificate verification enabled by default. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
insecure-skip-verify
branch
from
03c0f3b to
6ad2451
Compare
SamYuan1990
reviewed
Mar 11, 2026
| var conn *grpc.ClientConn | ||
| for i := 1; i <= 3; i++ { | ||
| conn, connError = gRPCClient.NewConnection(node.Addr, func(tlsConfig *tls.Config) { | ||
| tlsConfig.InsecureSkipVerify = true |
Contributor
There was a problem hiding this comment.
can we make it as a configurable value?
SamYuan1990
approved these changes
Mar 11, 2026
Contributor
SamYuan1990
left a comment
SamYuan1990
left a comment
There was a problem hiding this comment.
LGTM, but I want it can be configurable.
Member
Author
|
Client code can configure whatever gRPC connection options they want by using the gRPC APIs directly instead of the helper code in network.DialConnection (and related functions). See #238 for an example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The network.DialConnection function explicitly set InsecureSkipVerify to true on the tls.Config used to create gRPC connections. This change removes that behaviour, leaving TLS certificate verification enabled by default.