Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/frameworks/preact-webpack5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"prep": "jiti ../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/builder-webpack5": "7.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change replaces a local workspace dependency (workspace:*) with a fixed version from the public registry. This is likely to break the monorepo's dependency structure and cause build failures. The workspace:* protocol ensures that the local version of @storybook/builder-webpack5 from this repository is used, which is currently at version 8.3.0-beta.3.

Pinning to 7.1.0 is a significant downgrade and will introduce an outdated version of the package, likely causing inconsistencies and breaking changes. The security vulnerabilities Snyk is trying to fix may already be resolved in the newer workspace version.

It's recommended to revert this change. The vulnerabilities should be investigated within the context of the monorepo's dependency tree, possibly by updating transitive dependencies if needed, rather than changing this direct dependency linkage.

Suggested change
"@storybook/builder-webpack5": "7.1.0",
"@storybook/builder-webpack5": "workspace:*",

"@storybook/preact": "workspace:*",
"@storybook/preset-preact-webpack": "workspace:*",
"@types/node": "^22.0.0"
Expand Down
Loading