-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade @storybook/builder-webpack5 from 0.0.0-use.local to 7.1.0 #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
…lities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security update, upgrading a core Storybook dependency to mitigate known vulnerabilities. The primary goal is to enhance the project's security posture by incorporating the latest patched version of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix two security vulnerabilities by upgrading @storybook/builder-webpack5. However, the proposed change of pinning the version to 7.1.0 is incorrect for this monorepo setup. It replaces a local workspace dependency (workspace:*) with a fixed, outdated public version, which is a significant downgrade from the current workspace version (8.3.0-beta.3). This change will likely break the build and introduce inconsistencies. The warning in the PR description about the failure to update yarn.lock further indicates that this automated change is incompatible with the project's structure. I have added a critical comment suggesting to revert this change. The vulnerabilities should be addressed by analyzing the dependency tree of the local workspace package and updating its transitive dependencies if necessary.
| }, | ||
| "dependencies": { | ||
| "@storybook/builder-webpack5": "workspace:*", | ||
| "@storybook/builder-webpack5": "7.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change replaces a local workspace dependency (workspace:*) with a fixed version from the public registry. This is likely to break the monorepo's dependency structure and cause build failures. The workspace:* protocol ensures that the local version of @storybook/builder-webpack5 from this repository is used, which is currently at version 8.3.0-beta.3.
Pinning to 7.1.0 is a significant downgrade and will introduce an outdated version of the package, likely causing inconsistencies and breaking changes. The security vulnerabilities Snyk is trying to fix may already be resolved in the newer workspace version.
It's recommended to revert this change. The vulnerabilities should be investigated within the context of the monorepo's dependency tree, possibly by updating transitive dependencies if needed, rather than changing this direct dependency linkage.
| "@storybook/builder-webpack5": "7.1.0", | |
| "@storybook/builder-webpack5": "workspace:*", |
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/preact-webpack5/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-LODASH-15053838
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution