Acknowledge secret regeneration concern as tracked follow-up#59
Draft
Acknowledge secret regeneration concern as tracked follow-up#59
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Merged
Copilot
AI
changed the title
[WIP] Address feedback on Helm test fix from PR #57
Acknowledge secret regeneration concern as tracked follow-up
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review comment flagged that
genPrivateKeyandrandAlphaNuminpostal/templates/secret.yamlregenerate secrets on every Helm upgrade, risking service disruption. The reviewer requested this be deferred to a separate issue rather than addressed in the current PR.Changes
lookupfunction to preserve existing secret values across upgrades)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.