Conversation
neilime
force-pushed
the
ci/fix-helm-test
branch
from
e6782ad to
5807248
Compare
fredleger
force-pushed
the
ci/fix-helm-test
branch
from
ea775ea to
7bd8c25
Compare
|
@neilime for review please |
There was a problem hiding this comment.
Pull request overview
This PR fixes Helm chart testing by making the chart installable without requiring external dependencies like cert-manager to be pre-installed. It introduces self-signed certificate generation as the default TLS source and auto-generates secrets when not provided, enabling CI tests to run without manual secret configuration.
Changes:
- Added self-signed certificate support for SMTP TLS as an alternative to cert-manager
- Made secrets auto-generate with fallback values when not explicitly provided
- Reorganized CI test configuration files with numbered prefixes for proper load order
- Added cert-manager as an optional chart dependency (version 1.19.3)
- Updated MariaDB chart dependency from version 16.x to 24.1.1
Reviewed changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| postal/values.yaml | Changed default SMTP TLS source to self-signed, moved mariadb config to end, added cert-manager dependency config |
| postal/templates/smtp/tls-cert.yaml | Added self-signed certificate generation using Helm crypto functions |
| postal/templates/secret.yaml | Added fallback secret generation for signingKey and railsSecretKey |
| postal/ci/*.yaml | Deleted old CI value files and replaced with numbered versions containing actual test keys |
| postal/Chart.yaml | Added cert-manager dependency and updated mariadb from 16.. to 24.1.1 |
| postal/Chart.lock | Updated with new dependency versions and regenerated digest |
| .github/workflows/__shared-ci.yml | Added jetstack helm repository and cert-manager.enabled flag |
| .tool-versions | Reformatted and updated github-cli version |
| .gitignore | Added postal/charts/** to ignore downloaded dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@fredleger I've opened a new pull request, #59, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@fredleger I've opened a new pull request, #60, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@neilime ? ready to merge ? |
No description provided.