Conversation
…orm PTY support (Refs: beans-bz15) - Swap creack/pty (Unix-only, unmaintained) for go-pty which provides a unified API for Unix PTY and Windows ConPTY - Session struct now holds gopty.Pty interface + *gopty.Cmd instead of raw *os.File + *exec.Cmd - Add defaultShell() helper with Windows support (pwsh.exe/cmd.exe fallback) - No public API changes to Session or Manager
… Linux (Refs: beans-bz15) - go-pty keeps the slave fd open in the parent process after cmd.Start() - On Linux, this prevents the master from receiving EOF when the child exits - Add closeSlave() helper that closes the slave fd via the UnixPty interface - Fixes TestCreateWithCommandExits timeout on Linux CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
creack/pty(Unix-only, unmaintained) withaymanbagabas/go-ptywhich provides a unifiedPtyinterface for Unix PTY and Windows ConPTYSessionstruct now holdsgopty.Pty(io.ReadWriteCloser+Resize) and*gopty.Cmdinstead of raw*os.File+*exec.CmddefaultShell()helper that pickspwsh.exe/cmd.exeon Windows,$SHELLor/bin/shon UnixSessionandManagermethod signatures are unchangedcreack/ptyremains as an indirect dependency (go-pty wraps it on Unix)Test plan
internal/terminalincluded)