perf: faster escape html & unescape html#421
Open
SukkaW wants to merge 6 commits intohexojs:masterfrom
Open
Conversation
Member
|
before PR escapeHTML('&0') // => &0after PR escapeHTML('&0') // => &0Is this intentional? |
Member
Author
Hmmmm, extra check again. |
Member
Author
|
@D-Sketon Check again? Added extra check for |
Member
|
consider malformed entity patterns escapeHTML('�') // => � (#\d{1,7} ×)
escapeHTML('�') // => � (#[Xx][a-fA-F0-9]{1,6} ×)after PR escapeHTML('�') // => �
escapeHTML('�') // => � |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check list
Description
Recently, I have created the fastest HTMl escaping with plain JavaScript: fast-escape-html. It is even faster than the Rust counterpart with real-world HTML.
hexo-utilcan't usefast-escape-urldirectly sincehexo-utilsneeds to escape more characters (to work with swig/mustache.js/pug template languages), and also needs to avoid double escape.I have managed to modify
fast-escape-urlforhexo-util, and it still results in significant performance improvements. I have also slightly modifiedunescapeHTMLto use some performance techniques fromfast-escape-urlas well.The
escapeTMLbenchmark results are as follows.TL; DR: due to extra checks and look-ahead, the new
escapeHTMLwill never beat myfast-escape-url, but it is 145% faster than we currently have, and also beatslodash.escapeandescape-goat(that don't even check double escape, and they escape fewer symbols).