perf(escapeHTML): use multiple replace#178
Closed
SukkaW wants to merge 1 commit intohexojs:masterfrom
Closed
Conversation
a721cb7 to
087af71
Compare
Member
|
I modified the source text to include all special characters. The result of benchmark with Node v12 is reversal. The result of benchmark with Node v13 is same as SukkaW's report. It is certain that my sample source text is unusual HTML. |
tomap
approved these changes
Jan 15, 2022
Member
Author
|
More performance benchmark needs to be done before we merge this. |
Member
Author
|
Superseded by #421 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Benchmark: https://runkit.com/sukkaw/5e3003ffe7e84c0013f6210d
On my local computer,
Multiple replaceis the slower one under Node.js 10 but it is the faster one under Node.js 12 & 13: