Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Cabal/src/Distribution/Simple/Setup/Config.hs
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,6 @@ data ConfigFlags = ConfigFlags
, configExactConfiguration :: Flag Bool
-- ^ All direct dependencies and flags are provided on the command line by
-- the user via the '--dependency' and '--flags' options.
, configFlagError :: Flag String
-- ^ Halt and show an error message indicating an error in flag assignment
, configRelocatable :: Flag Bool
-- ^ Enable relocatable package built
, configDebugInfo :: Flag DebugInfoLevel
Expand Down Expand Up @@ -319,7 +317,6 @@ instance Eq ConfigFlags where
&& equal configCoverage
&& equal configLibCoverage
&& equal configExactConfiguration
&& equal configFlagError
&& equal configRelocatable
&& equal configDebugInfo
&& equal configDumpBuildInfo
Expand Down Expand Up @@ -366,7 +363,6 @@ defaultConfigFlags progDb =
, configCoverage = Flag False
, configLibCoverage = NoFlag
, configExactConfiguration = Flag False
, configFlagError = NoFlag
, configRelocatable = Flag False
, configDebugInfo = Flag NoDebugInfo
, configDumpBuildInfo = NoFlag
Expand Down
1 change: 0 additions & 1 deletion cabal-install/src/Distribution/Client/Config.hs
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,6 @@ instance Semigroup SavedConfig where
, configCoverage = combine configCoverage
, configLibCoverage = combine configLibCoverage
, configExactConfiguration = combine configExactConfiguration
, configFlagError = combine configFlagError
, configRelocatable = combine configRelocatable
, configUseResponseFiles = combine configUseResponseFiles
, configDumpBuildInfo = combine configDumpBuildInfo
Expand Down
2 changes: 0 additions & 2 deletions cabal-install/src/Distribution/Client/ProjectConfig/Legacy.hs
Original file line number Diff line number Diff line change
Expand Up @@ -1140,7 +1140,6 @@ convertToLegacyAllPackageConfig
, configLibCoverage = mempty -- TODO: don't merge
, configExactConfiguration = mempty
, configBenchmarks = mempty
, configFlagError = mempty -- TODO: ???
, configRelocatable = mempty
, configDebugInfo = mempty
, configUseResponseFiles = mempty
Expand Down Expand Up @@ -1216,7 +1215,6 @@ convertToLegacyPerPackageConfig PackageConfig{..} =
, configLibCoverage = packageConfigCoverage -- TODO: don't merge
, configExactConfiguration = mempty
, configBenchmarks = packageConfigBenchmarks
, configFlagError = mempty -- TODO: ???
, configRelocatable = packageConfigRelocatable
, configDebugInfo = packageConfigDebugInfo
, configUseResponseFiles = mempty
Expand Down
1 change: 0 additions & 1 deletion cabal-install/src/Distribution/Client/ProjectPlanning.hs
Original file line number Diff line number Diff line change
Expand Up @@ -4166,7 +4166,6 @@ setupHsConfigureFlags
ElabComponent _ -> mempty

configExactConfiguration = toFlag True
configFlagError = mempty -- TODO: [research required] appears not to be implemented
configScratchDir = mempty -- never use
configUserInstall = mempty -- don't rely on defaults
configPrograms_ = mempty -- never use, shouldn't exist
Expand Down
8 changes: 8 additions & 0 deletions changelog.d/pr-11480.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
synopsis: Remove unused config flag `configFlagError`
packages: [Cabal, cabal-install]
prs: 11480
---

Remove unused config flag `configFlagError`. This was added, but never used in any external
or internal behavior.
Loading