Open
Conversation
This commit removes the `configFlagError` field in ConfigFlags. This flag was never implemented and is currently not used by any internal or external function. Unless I'm missing some convention against removing flags, this shouldn't exist.
5eca4e2 to
5d5ff5e
Compare
Collaborator
|
@a-02 Looks like there is a test that needs to be adjusted. But in general I'm highly in favor of removing items that are not usable in any way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the
configFlagErrorfield in ConfigFlags.This flag was never implemented and is currently not used by any internal or external function. Unless I'm missing some convention against removing flags, this shouldn't exist.
Gimme a second to add in the stuff for template A.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: