Skip to content

Remove configFlagError#11480

Open
a-02 wants to merge 1 commit intohaskell:masterfrom
a-02:a-02/remove-dead-flags
Open

Remove configFlagError#11480
a-02 wants to merge 1 commit intohaskell:masterfrom
a-02:a-02/remove-dead-flags

Conversation

@a-02
Copy link

@a-02 a-02 commented Feb 8, 2026

This commit removes the configFlagError field in ConfigFlags.

This flag was never implemented and is currently not used by any internal or external function. Unless I'm missing some convention against removing flags, this shouldn't exist.

Gimme a second to add in the stuff for template A.


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

This commit removes the `configFlagError` field in ConfigFlags.

This flag was never implemented and is currently not used by any
internal or external function. Unless I'm missing some convention
against removing flags, this shouldn't exist.
@a-02 a-02 force-pushed the a-02/remove-dead-flags branch from 5eca4e2 to 5d5ff5e Compare February 8, 2026 17:04
@a-02 a-02 marked this pull request as ready for review February 8, 2026 17:11
@telser
Copy link
Collaborator

telser commented Feb 10, 2026

@a-02 Looks like there is a test that needs to be adjusted. But in general I'm highly in favor of removing items that are not usable in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants