Merged
Conversation
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
SlimaneAmar
reviewed
Feb 13, 2026
src/main/java/org/gridsuite/modification/modifications/CompositeModification.java
Show resolved
Hide resolved
SlimaneAmar
reviewed
Feb 13, 2026
| public class CompositeModificationInfos extends ModificationInfos { | ||
|
|
||
| @Schema(description = "composite modification name") | ||
| private String compositeName; |
Contributor
Author
There was a problem hiding this comment.
Composite modifications need to be identifiable by a name in order to be displayed in gridstudy and in the execution logs. This will allow for the users to rename the composites and organize them as folders.
I called it compositeName instead of just name because name is a forbidden variable name.
Contributor
There was a problem hiding this comment.
who say this forbidden sonar?
Contributor
Author
There was a problem hiding this comment.
Actually I just changed it back to just "name" and it seems to work fine. I don't remember what the problem was. Do you want me to change it to "name "?
Contributor
There was a problem hiding this comment.
I think it's better because it's already what we used in other entities or DTO.
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Meklo
reviewed
Feb 18, 2026
src/main/java/org/gridsuite/modification/dto/CompositeModificationInfos.java
Outdated
Show resolved
Hide resolved
flomillot
reviewed
Feb 18, 2026
src/main/java/org/gridsuite/modification/dto/ModificationsToCopyInfos.java
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/modifications/CompositeModification.java
Outdated
Show resolved
Hide resolved
| network.modification.limitSetAbsentOnSide1 = limit set '${selectedOperationalLimitsGroup}' on side 1 does not exist | ||
| network.modification.limitSetAbsentOnSide2 = limit set '${selectedOperationalLimitsGroup}' on side 2 does not exist | ||
| network.modification.composite = Composite modification : '${modificationName}' | ||
| network.modification.compositeReportException = Cannot execute ${modificationName} : ${errorMessage} |
Contributor
There was a problem hiding this comment.
Maybe something more nested ? Like it's done for tabular modifications.
src/test/java/org/gridsuite/modification/modifications/CompositeModificationsTest.java
Show resolved
Hide resolved
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Meklo
approved these changes
Feb 19, 2026
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
flomillot
approved these changes
Feb 20, 2026
| network.modification.limitSetAbsentOnSide1 = limit set '${selectedOperationalLimitsGroup}' on side 1 does not exist | ||
| network.modification.limitSetAbsentOnSide2 = limit set '${selectedOperationalLimitsGroup}' on side 2 does not exist | ||
| network.modification.composite.apply = Composite modification : '${modificationName}' | ||
| network.modification.composite.reportException = Cannot execute ${modificationName} : ${errorMessage} |
Contributor
There was a problem hiding this comment.
Suggested change
| network.modification.composite.reportException = Cannot execute ${modificationName} : ${errorMessage} | |
| network.modification.composite.exception.report = Cannot execute ${modificationName} : ${errorMessage} |
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable the application of the composite modification (not yet possible to add them from the front, this is a pure back ticket, checked via unit tests and swagger)
adds a name to the composite modifications