Skip to content

Comments

adds a name to the composite modifications + updates the composite creation endpoint#762

Merged
Mathieu-Deharbe merged 16 commits intomainfrom
apply-composite-modification
Feb 20, 2026
Merged

adds a name to the composite modifications + updates the composite creation endpoint#762
Mathieu-Deharbe merged 16 commits intomainfrom
apply-composite-modification

Conversation

@Mathieu-Deharbe
Copy link
Contributor

  • adds a name to the composite modifications
  • updates the composite creation endpoint

needs : gridsuite/network-modification#156

Mathieu-Deharbe and others added 5 commits February 6, 2026 14:46
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Meklo Meklo self-requested a review February 11, 2026 16:14
Copy link
Contributor

@Meklo Meklo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evolving ModificationInfos to include composite subModification and its name in the message values will be done later ?

Additionally I've noticed when using INSERT_COMPOSITE it create two new entries in composite_modification table which corresponds to two modifications, one with the targetted group_uuid and one with a blank group_uuid, is this intended or a mishap on my side ?

Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe
Copy link
Contributor Author

Mathieu-Deharbe commented Feb 13, 2026

Evolving ModificationInfos to include composite subModification and its name in the message values will be done later ?

I didn't think of that. Edit after discussion => not really the scope, will probably be added to the visualisation ticket, to be checked with the POs

Additionally I've noticed when using INSERT_COMPOSITE it create two new entries in composite_modification table which corresponds to two modifications, one with the targetted group_uuid and one with a blank group_uuid, is this intended or a mishap on my side ?

I just checked : you seem to be right ! Sorry, I will look into it. => Edit : corrected

Mathieu-Deharbe and others added 2 commits February 17, 2026 10:24
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@flomillot flomillot self-requested a review February 18, 2026 16:04
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@sonarqubecloud
Copy link

@Mathieu-Deharbe Mathieu-Deharbe merged commit 5520942 into main Feb 20, 2026
3 checks passed
@Mathieu-Deharbe Mathieu-Deharbe deleted the apply-composite-modification branch February 20, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants