fix(config): validate label characters in Pyroscope config#298
Merged
Conversation
Reject appName and tag keys/values containing Prometheus label syntax
characters ({, }, ,, =) during config validation.
korniltsev-grafanista
changed the title
jake-kramer
previously approved these changes
Jul 2, 2026
jake-kramer
left a comment
jake-kramer
left a comment
Contributor
There was a problem hiding this comment.
Would be great to get a test for this, even if it's just an end-to-end failure
|
|
||
| if (typeof tagValue === 'string' && hasInvalidLabelCharacters(tagValue)) { | ||
| errors.push( | ||
| `tag value for "${tagKey}" must not contain ${INVALID_LABEL_CHARACTERS_MESSAGE}` |
Contributor
There was a problem hiding this comment.
In this message and one below would be helpful to log the tagValue too
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jake-kramer
approved these changes
Jul 3, 2026
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appNameand tag keys/values that contain Prometheus label syntax characters ({,},,,=) during config validationTest plan
yarn testappName/ tag values produce clear validation errors at init time