chore: Validate label characters #297
Closed
korniltsev-grafanista wants to merge 2 commits into
Closed
Conversation
Reject appName and tag keys/values containing Prometheus label syntax characters, and replace .tool-versions with mise.toml including corepack for Yarn on Node 26.
Align local and CI Node pins with the latest 26.x release.
korniltsev-grafanista
changed the title
Contributor
Author
|
Split into two PRs for easier review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appNameand tag keys/values that contain Prometheus label syntax characters ({,},,,=) during config validation.tool-versionswithmise.toml, pinning Node 26.2.0 and installing corepack 0.35.0 so Yarn 4.15.0 works on Node 26 (which no longer bundles corepack)