feat: add trace_id pprof label#89
Conversation
|
|
1 similar comment
|
|
568e680 to
86d019e
Compare
simonswine
left a comment
There was a problem hiding this comment.
Needs rebase to pass the tests, but in general looks good to me
3d8f35d to
c0d36fd
Compare
ee61f37 to
b2327dc
Compare
|
wait, why does querying by trace_id series label work on your screenshot? I thought we removed trace_id label same way as span_id |
Yes, this was the first test I did on all the SDKs before the fix I did on Pyroscope. |
Summary
Attaches a
trace_idpprof label (32-char W3C hex) to profile samples, enabling traces↔profiles correlation by trace ID server-side. Emitted unconditionally, matching the Go/Python SDKs;span_idandpyroscope.profile.idbehavior is unchanged.Uses the
ProfilerApi.setTraceId(String)/clearTraceId()methods added in grafana/pyroscope-java#313 (the otel-extension path). The library processor calls the nativeAsyncProfiler.setTraceId(hi, lo)directly, with an allocation-free hex parser.Requires pyroscope-java >= 2.6.0 (now on Maven Central).