fix: exclude trace_id from sample to series label promotion#5220
Merged
Conversation
marcsanmi
requested review from
bryanhuhta and
korniltsev-grafanista
as code owners
korniltsev-grafanista
approved these changes
Jun 2, 2026
therealvio
pushed a commit
to chinmina/chinmina-bridge
that referenced
this pull request
Jul 6, 2026
….6.0 (#312) This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Adoption](https://docs.renovatebot.com/merge-confidence/) | [Passing](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---|---|---| | [github.com/grafana/otel-profiling-go](https://redirect.github.com/grafana/otel-profiling-go) | `v0.5.1` → `v0.6.0` |  |  |  |  | --- ### Release Notes <details> <summary>grafana/otel-profiling-go (github.com/grafana/otel-profiling-go)</summary> ### [`v0.6.0`](https://redirect.github.com/grafana/otel-profiling-go/releases/tag/v0.6.0) [Compare Source](https://redirect.github.com/grafana/otel-profiling-go/compare/v0.5.3...v0.6.0) Adds a `trace_id` pprof label for traces↔profiles correlation by trace ID. #####⚠️ Compatibility `trace_id` is emitted unconditionally and requires a Pyroscope server with the fix from [grafana/pyroscope#5220](https://redirect.github.com/grafana/pyroscope/pull/5220), included in v2.1.0 or newer. On servers without it, `trace_id` is promoted to a per-trace series label and inflates the index, so upgrade the server first. ### [`v0.5.3`](https://redirect.github.com/grafana/otel-profiling-go/compare/v0.5.2...v0.5.3) [Compare Source](https://redirect.github.com/grafana/otel-profiling-go/compare/v0.5.2...v0.5.3) ### [`v0.5.2`](https://redirect.github.com/grafana/otel-profiling-go/compare/v0.5.1...v0.5.2) [Compare Source](https://redirect.github.com/grafana/otel-profiling-go/compare/v0.5.1...v0.5.2) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/chinmina/chinmina-bridge). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNDIuMiIsInVwZGF0ZWRJblZlciI6IjQzLjI0Mi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The distributor's sample split currently promotes every sample label other than
span_idto a series label, indexing it in TSDB; we can see in the screenshot of this PR, wheretrace_idis available as a series label.Since it has high cardinality, promoting it would inflate the series index unboundedly once the SDK PRs that emit
trace_idship.This excludes
trace_idalongsidespan_idinpprofsplit.VisitSampleSeries, keeping it at the sample level where the existing dedicated parquet column already stores it. Includes a regression test covering both labels.