Clean up legacy setup scripts and simplify shell functions#9
Merged
Conversation
- Delete setup/install/ (superseded by setup/*.sh) - Delete setup/install-linux.sh and setup/base.yml (old Ansible approach) - Delete root NOTES.md (personal scratchpad) and docs/build_cool_retro_term (unrelated one-off) - Remove Legacy section from setup/NOTES.md - Fix justfile fmt/lint recipes to not reference removed setup/install/ - Clean up functions: remove dead nerdfont_icon_search (broken RUNCOM2_PATH ref), emoji_search (emojify not installed), dedup_pathvar/get_var/set_var (TODO/untested); simplify git_user_name_prompt_mkii; drop dead comments https://claude.ai/code/session_014GE7w3BJQ25yV9nb7rN7jk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes obsolete setup scripts and installation utilities, while simplifying the shell functions library by removing unused or overly complex helper functions.
Key Changes
Removed Files:
docs/build_cool_retro_term_mac_homebrew_2025.sh- macOS-specific build script for Cool Retro Term (no longer maintained)setup/base.yml- Ansible playbook for base package installation (superseded by newer approach)setup/install/directory - Legacy installation scripts for:Simplified Functions (
functionsfile):get_var(),set_var(), anddedup_pathvar()- unused path deduplication utilities with known issuesgit_user_name_prompt_mkii()- removed redundant conditional logic, now directly returns formatted emailsave()- removed commented-out debug codecenter-text()- removed function keyword (shell-agnostic), removed commented-out codenerdfont_icon_search()- unused nerd font search utilityemoji_search()- unused emoji search utilityUpdated Build Configuration:
justfilefmt and lint targets to only processsetup/*.sh(removed references to deletedsetup/install/*.sh)setup/NOTES.mdto remove reference to legacyinstall/subdirectoryRationale
These changes clean up the repository by removing deprecated, unmaintained, or superseded setup approaches. The legacy installation scripts have been replaced with more modern tooling and approaches. The simplified shell functions remove dead code and improve maintainability.
https://claude.ai/code/session_014GE7w3BJQ25yV9nb7rN7jk