Skip to content

Update: Adjust SPX tutorial text and font color #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hejiaping-pipi wants to merge 1 commit into
base: ui
Choose a base branch
from
Open

Update: Adjust SPX tutorial text and font color #3171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions ui/pages/spx/tutorial.pen
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"id": "ong2L",
"type": "ref",
"ref": "P:WiWwa",
"x": 0.0001975079347187812,
"x": 0.00018589109107464467,
Copy link
Copy Markdown
Contributor

@fennoai fennoai Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintentional sub-pixel x-position drift?

The x value changed from 0.0001975... to 0.00018589... — both are effectively zero at any display resolution. This looks like an accidental artifact of a design-tool re-export rather than a deliberate positional adjustment. If it wasn't intentional, reverting it keeps the file history clean.

"y": 0,
"children": [
{
Expand Down Expand Up @@ -121,7 +121,7 @@
"ref": "P:OHwu4",
"x": 0.07806559948336479,
"y": 0,
"content": "All Tutorials"
"content": "change"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The text "change" appears to be a placeholder or a typo. It should be a descriptive title for the tutorial page, such as "All Tutorials" or a localized string key if the project supports internationalization in these files.

Copy link
Copy Markdown
Contributor

@fennoai fennoai Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder text left in content field.

The label "All Tutorials" was replaced with "change", which reads as a forgotten placeholder or an in-progress note that was never replaced with the intended final copy. This string would be rendered verbatim to users as the tutorial section heading.

Other headings in the same file use proper copy (e.g. "Explore the User Tutorial"). Please replace "change" with the intended display text before merging.

},
{
"type": "frame",
Expand Down Expand Up @@ -154,7 +154,12 @@
{
"id": "gqB7m",
"type": "ref",
"ref": "P:XzIf9"
"ref": "P:XzIf9",
"descendants": {
"P:W0vhG5": {
"fill": "$P:code-operator"
}
}
Comment on lines +158 to +162
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The $P:code-operator fill style is applied to this tutorial item and the one at line 180, but it is missing from several other identical items in this file (e.g., lines 201, 218, 245, etc.) that use the same P:XzIf9 reference. Please ensure the style is applied consistently across all tutorial items.

}
Comment on lines +157 to 163
Copy link
Copy Markdown
Contributor

@fennoai fennoai Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete rollout of the descendants color override.

The fill: $P:code-operator override for P:W0vhG5 is applied to only two of the tutorial card refs (gqB7m and v3LEr). The same row and the second row contain additional card refs that do not receive the override, which would produce visual inconsistency across cards.

If the intent is a uniform color change across all tutorial cards, the descendants block should be added to all remaining refs as well. If selective application is intentional, please document the reasoning in the PR description.

]
},
Expand All @@ -171,7 +176,12 @@
{
"id": "v3LEr",
"type": "ref",
"ref": "P:XzIf9"
"ref": "P:XzIf9",
"descendants": {
"P:W0vhG5": {
"fill": "$P:code-operator"
}
}
}
]
},
Expand Down