Update: Adjust SPX tutorial text and font color#3171
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the UI configuration in tutorial.pen, including minor coordinate adjustments, a label change, and the addition of specific styling to tutorial reference items. Feedback suggests that the label "change" appears to be a placeholder and should be replaced with a descriptive title. Furthermore, the reviewer recommended ensuring that the new styling is applied consistently across all similar items in the file.
| "x": 0.07806559948336479, | ||
| "y": 0, | ||
| "content": "All Tutorials" | ||
| "content": "change" |
| "descendants": { | ||
| "P:W0vhG5": { | ||
| "fill": "$P:code-operator" | ||
| } | ||
| } |
There was a problem hiding this comment.
The $P:code-operator fill style is applied to this tutorial item and the one at line 180, but it is missing from several other identical items in this file (e.g., lines 201, 218, 245, etc.) that use the same P:XzIf9 reference. Please ensure the style is applied consistently across all tutorial items.
There was a problem hiding this comment.
Code Review Summary
This PR modifies ui/pages/spx/tutorial.pen with three changes: a section heading text update, a color token override for tutorial card text, and a minor x-position nudge. One critical issue and two minor observations are noted below.
No security issues found.
| "x": 0.07806559948336479, | ||
| "y": 0, | ||
| "content": "All Tutorials" | ||
| "content": "change" |
There was a problem hiding this comment.
Placeholder text left in content field.
The label "All Tutorials" was replaced with "change", which reads as a forgotten placeholder or an in-progress note that was never replaced with the intended final copy. This string would be rendered verbatim to users as the tutorial section heading.
Other headings in the same file use proper copy (e.g. "Explore the User Tutorial"). Please replace "change" with the intended display text before merging.
| "ref": "P:XzIf9", | ||
| "descendants": { | ||
| "P:W0vhG5": { | ||
| "fill": "$P:code-operator" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Incomplete rollout of the descendants color override.
The fill: $P:code-operator override for P:W0vhG5 is applied to only two of the tutorial card refs (gqB7m and v3LEr). The same row and the second row contain additional card refs that do not receive the override, which would produce visual inconsistency across cards.
If the intent is a uniform color change across all tutorial cards, the descendants block should be added to all remaining refs as well. If selective application is intentional, please document the reasoning in the PR description.
| "type": "ref", | ||
| "ref": "P:WiWwa", | ||
| "x": 0.0001975079347187812, | ||
| "x": 0.00018589109107464467, |
There was a problem hiding this comment.
Unintentional sub-pixel x-position drift?
The x value changed from 0.0001975... to 0.00018589... — both are effectively zero at any display resolution. This looks like an accidental artifact of a design-tool re-export rather than a deliberate positional adjustment. If it wasn't intentional, reverting it keeps the file history clean.
Issue
N/A
Background
Update the SPX tutorial page display text and refine the font color styling for tutorial items.
Changes
All Tutorialstochange$P:code-operatorfill to tutorial item text stylesScope
ui/pages/spx/tutorial.penDesign System Impact