-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(bigframes): include pyopenssl as a dependency #17362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
eab1633
01afa12
478090f
7aacf90
addc623
13549bc
5335a7c
7851eab
300352b
b9fb3de
78dadaa
c73de14
74035ce
0094602
732d5cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| SELECT | ||
| `rowindex`, | ||
| ROUND(`int64_col` + `int64_too`) AS `0` | ||
| FROM `bigframes-dev`.`sqlglot_test`.`scalar_types` AS `bft_0` | ||
| FROM `bigframes-dev`.`sqlglot_test`.`scalar_types` AS `bft_0` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| SELECT | ||
| `rowindex`, | ||
| ROUND(`int64_col` + `int64_too`) AS `0` | ||
| FROM `bigframes-dev`.`sqlglot_test`.`scalar_types` AS `bft_0` | ||
| FROM `bigframes-dev`.`sqlglot_test`.`scalar_types` AS `bft_0` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,10 @@ | |
|
|
||
| pytest.importorskip("pytest_snapshot") | ||
|
|
||
| # Only test on the latest pandas since column naming behavior is slightly | ||
| # different across versions, e.g. unnamed vs 0 for unnamed Series. | ||
| pytest.importorskip("pandas", minversion="3.0.0") | ||
|
|
||
|
|
||
| def test_sql_scalar(scalar_types_df: bpd.DataFrame, snapshot, monkeypatch): | ||
| session = mock.create_autospec(bigframes.session.Session) | ||
|
|
@@ -42,7 +46,7 @@ def to_pandas(series, *, ordered): | |
| ) | ||
|
|
||
| session.read_pandas.assert_called_once() | ||
| snapshot.assert_match(result, "out.sql") | ||
| snapshot.assert_match(result.strip() + "\n", "out.sql") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would this issue impact every snapshot? I assume this is from mismatch between sqlglot version locally vs on the automated test runs?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's actually not a version mismatch. It's because I was fighting the |
||
|
|
||
|
|
||
| def test_bigframes_sql_scalar(scalar_types_df: bpd.DataFrame, snapshot): | ||
|
|
@@ -57,4 +61,4 @@ def test_bigframes_sql_scalar(scalar_types_df: bpd.DataFrame, snapshot): | |
| session.read_pandas.assert_not_called() | ||
| # Bigframes implementation returns a bigframes.series.Series | ||
| sql, _, _ = result.to_frame()._to_sql_query(include_index=True) | ||
| snapshot.assert_match(sql, "out.sql") | ||
| snapshot.assert_match(sql.strip() + "\n", "out.sql") | ||
Uh oh!
There was an error while loading. Please reload this page.