fix(bigframes): include pyopenssl as a dependency#17362
Conversation
Also, support pandas 3.0 in various system tests.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the google-auth dependency to include pyopenssl and modifies test files to handle pandas compatibility. Specifically, it introduces conditional checks for applymap versus map and updates magic test assertions. The review feedback correctly points out that checking for applymap first will still trigger FutureWarning deprecation warnings in pandas 2.1.x and 2.2.x, and suggests checking for the newer map method first instead.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
|
||
| session.read_pandas.assert_called_once() | ||
| snapshot.assert_match(result, "out.sql") | ||
| snapshot.assert_match(result.strip() + "\n", "out.sql") |
There was a problem hiding this comment.
Would this issue impact every snapshot? I assume this is from mismatch between sqlglot version locally vs on the automated test runs?
There was a problem hiding this comment.
It's actually not a version mismatch. It's because I was fighting the pre-commit end-of-file newline "fixer". Basically, I'm applying that change here so that when we re-run it, the "fixer" won't see it as a problem because it's looking for exactly 1 trailing newline character.
2 participants
Also, support pandas 3.0 in various system tests.
Internal issue b/519591816 🦕